From mboxrd@z Thu Jan  1 00:00:00 1970
From: ummeegge <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Prevent internal server error cause of bad
 header wrapper
Date: Mon, 02 Jul 2018 14:26:05 +0200
Message-ID: <1530534365.8568.1.camel@ipfire.org>
In-Reply-To: <1529572373-16580-1-git-send-email-erik.kapfer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7430458717982711583=="
List-Id: <development.lists.ipfire.org>

--===============7430458717982711583==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hi,
just wanted to know if this fix will be applied ?

Best,

Erik


Am Donnerstag, den 21.06.2018, 11:12 +0200 schrieb Erik Kapfer:
> This fixes #11772 .
> 
> If the X509 are deleted, the openvpnctrl output generates a bad
> header wrapper error from the CGI
> which causes an internal server error. The redirection of the
> openvpnctrl output fixes this.
> 
> Signed-off-by: Erik Kapfer <erik.kapfer(a)ipfire.org>
> ---
>  html/cgi-bin/ovpnmain.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 4bc3473..5cd19a0 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -1181,7 +1181,7 @@ SETTINGS_ERROR:
>  	    delete $confighash{$cgiparams{'$key'}};
>  	}
>  
> -	system ("/usr/local/bin/openvpnctrl -drrd $name");
> +	system ("/usr/local/bin/openvpnctrl -drrd $name
> &>/dev/null");
>      }
>      while ($file = glob("${General::swroot}/ovpn/ca/*")) {
>  	unlink $file;

--===============7430458717982711583==--