Re: [PATCH] OpenVPN: Prevent internal server error cause of bad header wrapper

[ummeegge <ummeegge@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

Hi Michael,

Am Dienstag, den 03.07.2018, 15:31 +0100 schrieb Michael Tremer:
> Hi,
> 
> On Tue, 2018-07-03 at 14:18 +0200, ummeegge wrote:
> > 
> > Hi Michael,
> > thanks for merging. I have seen that you´d applied version 1 of
> > this
> > patch
> > https://git.ipfire.org/?p=ipfire-2.x.git;a=blobdiff;f=html/cgi-bin/
> > ovpnmain.cg
> > i;h=c0c7cff6d87f6e18206129ab196172be61683a38;hp=5cd19a0f38f564c54e6
> > 72814e0b591
> > 8134889b17;hb=15a3aa45cf27c61a581f892b5f3a3905335a12b0;hpb=8ae4010b
> > 312830bce82
> > 721325f0aeae524b2810a
> > 
> > but there´s a version 2 of it 
> > https://patchwork.ipfire.org/patch/1842/ 
> > which we should in any case prefer.
> Oh sorry. If you can, please mark the v1 as such in Patchwork. I am
> not sure if
> we can trigger this automatically via email.
You mean to mark the first patch as v1 ? In that case i need to setup
the old patch again as a new one and send it as answer to the v2 patch.

> > 
> > P.S. I do have some more OpenVPN patches (extensions no bugs),
> > should i commit
> > some more or should we wait until the next release ?
> What are those?
Wanted to finish the 2.4 OpenVPN project in the course which we did
discussed some time ago. So i thought about this order:

1) Automatic cipher negotiation for RWs only (checkbox in advanced
section)
2) tls-crypt for N2N only (checkbox in N2N main menu).
3) LZ4 compression possibility for N2N and RW (menu with possiblity for
none, lzo, lz4v2)
4) Clean up ovpnmain.cgi from mtu-discovery since there are some old
code blocks left.

There is more but to get the old list shorter for the first.

Best,

Erik