From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Hofmann To: development@lists.ipfire.org Subject: Re: [PATCH v2 1/6] zoneconf.cgi: Change NIC display order, improve code Date: Sun, 21 Feb 2021 13:14:15 +0100 Message-ID: <156e9dea-e65d-57c3-ea6d-27ce0306f424@leo-andres.de> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0699090741327835503==" List-Id: --===============0699090741327835503== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, thank you for all your positive feedback and support! I like the working atmo= sphere here very much. (Sorry for the "off-topic" mail, but I think this is worth mentioning and app= reciating!) Looking forward to the test results! Best, Leo Am 19.02.2021 um 20:26 schrieb Michael Tremer: > Hello, > >> On 18 Feb 2021, at 14:36, Leo Hofmann wrote: >> >> Hi all, >> >> you probably already saw this patchset last month :) >> >> I have implemented your suggestions and decided to resubmit the entire pat= chset to keep it coherent. >> The patches 1-4 are unchanged. Daniel and Michael have already tested them= (thank you very much!). >> >> Patch 5 makes zoneconf use the new zone detection functions in network-fun= ctions.pl. This also fixes bug #12568! >> Patch 6 adds default values to the input fields. I decided to add a defaul= t VLAN ID as well, because these inputs suffered from the same usability issu= e as the STP priority fields. >> >> I'm looking forward to your feedback! > Thank you very much for working on this. > > Judging from the code, this looks very good. Nice and tidy and changes are = split into small chunks that are very easy to review. > > I will wait for some more people to give any feedback - and hopefully test = it live - and merge it. > > Well done! > > -Michael > >> Best regards, >> Leo >> >> P.S. @Daniel thanks for your help with re-submitting! I have read through = all your emails again and decided that I can submit these patches now. >> --===============0699090741327835503==--