Re: [PATCH 2/3] alsa: Fixes Bug#13087 - adds module removal for stopping alsa.

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2171 bytes --]

Hi Arne,

On 02/05/2023 10:55, Arne Fitzenreiter wrote:
> I think this will not work.
> You have to run "alsctl store" to save the mixer settings before you unload the modules.
Thanks for flagging this up. I hadn't thought of that. I will fix it.
> 
> There are also some *.conf files commented in the rootfiles. Also complains that they are missing since some
> versions. (still work on my hardware anyways.)
> Please include it to the package.
I will find them and uncomment them in the rootfile.

What is the best way to submit these updates. Just a v2 update for the patch 2/3 plus another patch for the rootfile update or should I do a v2 patch submission for the complete set of three patches from the original set together with an additional patch for the rootfile changes?

Regards,

Adolf.
> 
> Arne
> 
> 
> Am 2023-04-21 23:15, schrieb Adolf Belka:
>> - Stopping alsa or uninstalling it left the sound modules installed
>> until a reboot was
>>    carried out. Uninstallation or stopping the kernel modules should
>> also unload them.
>>    This patch adds in the modprobe -r commands to unload all the snd
>> modules installed
>>    with the start command. The stop command is then added into the
>> uninstall script to
>>    remove the modules.
>>
>> Fixes: Bug#13087
>> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>>  src/initscripts/packages/alsa | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/src/initscripts/packages/alsa b/src/initscripts/packages/alsa
>> index 348e33846..3bfb69f62 100644
>> --- a/src/initscripts/packages/alsa
>> +++ b/src/initscripts/packages/alsa
>> @@ -33,6 +33,10 @@ case "$1" in
>>          ;;
>>      stop)
>>          boot_mesg "Stopping ALSA...    Saving volumes..."
>> +        modprobe -r snd_pcm_oss >/dev/null 2>&1 || failed=1
>> +        modprobe -r snd_timer >/dev/null 2>&1 || failed=1
>> +        (exit ${failed})
>> +        evaluate_retval
>>          loadproc /usr/sbin/alsactl store
>>          ;;