From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/3] alsa: Fixes Bug#13087 - adds module removal for
 stopping alsa.
Date: Wed, 03 May 2023 13:47:12 +0200
Message-ID: <15b4f52f-d006-41b8-a0b6-23df03046fd9@ipfire.org>
In-Reply-To: <58a6df3f6c245880f279116096763426@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8812384039552429741=="
List-Id: <development.lists.ipfire.org>

--===============8812384039552429741==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Arne,

On 02/05/2023 10:55, Arne Fitzenreiter wrote:
> I think this will not work.
> You have to run "alsctl store" to save the mixer settings before you unload=
 the modules.
Thanks for flagging this up. I hadn't thought of that. I will fix it.
>=20
> There are also some *.conf files commented in the rootfiles. Also complains=
 that they are missing since some
> versions. (still work on my hardware anyways.)
> Please include it to the package.
I will find them and uncomment them in the rootfile.

What is the best way to submit these updates. Just a v2 update for the patch =
2/3 plus another patch for the rootfile update or should I do a v2 patch subm=
ission for the complete set of three patches from the original set together w=
ith an additional patch for the rootfile changes?

Regards,

Adolf.
>=20
> Arne
>=20
>=20
> Am 2023-04-21 23:15, schrieb Adolf Belka:
>> - Stopping alsa or uninstalling it left the sound modules installed
>> until a reboot was
>> =C2=A0=C2=A0 carried out. Uninstallation or stopping the kernel modules sh=
ould
>> also unload them.
>> =C2=A0=C2=A0 This patch adds in the modprobe -r commands to unload all the=
 snd
>> modules installed
>> =C2=A0=C2=A0 with the start command. The stop command is then added into t=
he
>> uninstall script to
>> =C2=A0=C2=A0 remove the modules.
>>
>> Fixes: Bug#13087
>> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
>> ---
>> =C2=A0src/initscripts/packages/alsa | 4 ++++
>> =C2=A01 file changed, 4 insertions(+)
>>
>> diff --git a/src/initscripts/packages/alsa b/src/initscripts/packages/alsa
>> index 348e33846..3bfb69f62 100644
>> --- a/src/initscripts/packages/alsa
>> +++ b/src/initscripts/packages/alsa
>> @@ -33,6 +33,10 @@ case "$1" in
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;;
>> =C2=A0=C2=A0=C2=A0=C2=A0 stop)
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 boot_mesg "Stopping ALSA.=
..=C2=A0=C2=A0=C2=A0 Saving volumes..."
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 modprobe -r snd_pcm_oss >/dev/=
null 2>&1 || failed=3D1
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 modprobe -r snd_timer >/dev/nu=
ll 2>&1 || failed=3D1
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (exit ${failed})
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 evaluate_retval
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 loadproc /usr/sbin/alsact=
l store
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;;

--===============8812384039552429741==--