public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] tor: Fix tor permissions if presant via update.sh
Date: Mon, 10 Jun 2019 18:12:00 +0000	[thread overview]
Message-ID: <16323d1c-c9d0-4675-136c-cdd075e3a0e0@ipfire.org> (raw)
In-Reply-To: <EF99C8E3-1BBB-41D5-B87B-1E22967D35A7@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

Hello Michael,

as mentioned in https://bugzilla.ipfire.org/show_bug.cgi?id=12088#c11 ,
the "install.sh" script of the Tor addon contains all required steps.

Since "update.sh" calls "install.sh" at the end of the file, everything
should be fine after an update as well - which is not. However, due to
this, I do not think putting it into "update.sh" makes sense either.

Thanks, and best regards,
Peter Müller

Michael Tremer:
> Hi,
> 
> Thanks for sending in that patch.
> 
> But I think instead of doing this in the Core Update, this change should be applied in the tor update scripts.
> 
> -Michael
> 
>> On 10 Jun 2019, at 12:36, Erik Kapfer <ummeegge(a)ipfire.org> wrote:
>>
>> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
>> ---
>> config/rootfiles/core/133/update.sh | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/config/rootfiles/core/133/update.sh b/config/rootfiles/core/133/update.sh
>> index a05ad0741..3ecb5651b 100644
>> --- a/config/rootfiles/core/133/update.sh
>> +++ b/config/rootfiles/core/133/update.sh
>> @@ -71,6 +71,11 @@ sudo -u nobody /srv/web/ipfire/cgi-bin/vpnmain.cgi
>> /etc/init.d/squid start
>> /etc/init.d/collectd restart
>>
>> +# Set new permissions for tor
>> +if [ -d "/var/lib/tor" ]; then
>> +    chown -R tor:tor /var/lib/tor
>> +fi
>> +
>> # Finish
>> /etc/init.d/fireinfo start
>> sendprofile
>> -- 
>> 2.12.2
>>
> 

-- 
The road to Hades is easy to travel.
	-- Bion of Borysthenes

  reply	other threads:[~2019-06-10 18:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 11:36 Erik Kapfer
2019-06-10 14:31 ` Michael Tremer
2019-06-10 18:12   ` Peter Müller [this message]
2019-06-10 18:36     ` Paul Simmons
2019-06-10 18:51       ` Michael Tremer
2019-06-10 19:02         ` [PATCH] Tor: fix permissions after updating, too Peter Müller
2019-06-12 13:57           ` Peter Müller
2019-06-12 14:12             ` Michael Tremer
2019-06-10 19:10     ` [PATCH] tor: Fix tor permissions if presant via update.sh ummeegge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16323d1c-c9d0-4675-136c-cdd075e3a0e0@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox