From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] tor: Fix tor permissions if presant via update.sh Date: Mon, 10 Jun 2019 18:12:00 +0000 Message-ID: <16323d1c-c9d0-4675-136c-cdd075e3a0e0@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4417816900321594179==" List-Id: --===============4417816900321594179== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, as mentioned in https://bugzilla.ipfire.org/show_bug.cgi?id=3D12088#c11 , the "install.sh" script of the Tor addon contains all required steps. Since "update.sh" calls "install.sh" at the end of the file, everything should be fine after an update as well - which is not. However, due to this, I do not think putting it into "update.sh" makes sense either. Thanks, and best regards, Peter M=C3=BCller Michael Tremer: > Hi, >=20 > Thanks for sending in that patch. >=20 > But I think instead of doing this in the Core Update, this change should be= applied in the tor update scripts. >=20 > -Michael >=20 >> On 10 Jun 2019, at 12:36, Erik Kapfer wrote: >> >> Signed-off-by: Erik Kapfer >> --- >> config/rootfiles/core/133/update.sh | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/config/rootfiles/core/133/update.sh b/config/rootfiles/core/1= 33/update.sh >> index a05ad0741..3ecb5651b 100644 >> --- a/config/rootfiles/core/133/update.sh >> +++ b/config/rootfiles/core/133/update.sh >> @@ -71,6 +71,11 @@ sudo -u nobody /srv/web/ipfire/cgi-bin/vpnmain.cgi >> /etc/init.d/squid start >> /etc/init.d/collectd restart >> >> +# Set new permissions for tor >> +if [ -d "/var/lib/tor" ]; then >> + chown -R tor:tor /var/lib/tor >> +fi >> + >> # Finish >> /etc/init.d/fireinfo start >> sendprofile >> --=20 >> 2.12.2 >> >=20 --=20 The road to Hades is easy to travel. -- Bion of Borysthenes --===============4417816900321594179==--