Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 31 Jul 2021, at 22:50, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> - Update from 2.8.8 to 2.10.0
> - Update of rootfile carried out
> - Changelog
>  2.10.0:
>    [ tatsuz ]
>   * updated Visual Studio projects to VS 2019 (#54)
>    [ Fabian Greffrath ]
>   * mp4read.c: fix stack-buffer-overflow in stringin()/ftypin()
>   * fix heap-buffer-overflow in mp4read.c
>    [ Clayton Smith ]
>   * Remove non-ASCII characters
>   * Remove trailing whitespace
>    [ Andrew Wesie ]
>   * Check return value of ltp_data.
>   * Restrict SBR frame length to 960 and 1024 samples.
>   * Support object type 29.
>   * Support implicit SBR signaling in frontend.
>   * Fix PNS decoding when only right channel is noise.
>   * Initialize element_id array with an invalid id.
>   * Fix NULL pointer dereferences.
>   * Fix infinite loop in adts_parse.
>   * Fix infinite loop in huffman_getescape.
>   * Check for error after each channel decode.
>   * Check for inconsistent number of channels.
>  2.9.2:
>    [ Michał Janiszewski ]
>   * Only use x86-assembly when explicitly on x86
>   * Use unsigned integers correctly
>   * Initialize pointers that might otherwise not be
>    [ Fabian Greffrath ]
>   * update README esp. WRT directory structure
>    [ Rosen Penev ]
>   * fix compilation without SBR/PS_DEC (#48)
>   * fix compilation with LC_ONLY_DECODER (#47)
>    [ Fabian Greffrath ]
>   * fix "inline function 'cfftf1' declared but never defined" compiler warning
>   * fix some inconsistencies in the frontend output
>   * mp4read_open: add check for failed frame buffer allocation
>   * stszin: add check for allocation error and integer overflow
>   * add a pkg-config file
>    [ Stefan Pöschel ]
>   * frontend: address compile warning + add missing LF (#50)
>    [ François Cartegnie ]
>   * library name is faad (#52)
>   * Unbreak PS audio (#51)
>  2.9.1:
>    [ Fabian Greffrath ]
>   * Include stdio.h in libfaad/ps_dec.c for stderr (Michael Fink)
>   * Fix Tille -> Title typo in frontend/mp4read.c (Alexander Thomas)
>  2.9.0:
>    [ Krzysztof Nikiel ]
>   * Build system fixes and code clean-up
>    [ LoRd_MuldeR ]
>   * Fix compiler warnings and code indentation
>   * Fix compilation with GCC <= 4.7.3
>   * MSVC solution file clean-up
>    [ Cameron Cawley ]
>   * Fix compilation with GCC 4.7.4
>   * Fix compilation with MinGW
>    [ Michael Fink ]
>   * MSVC 2017 project file update
>    [ Hugo Lefeuvre ]
>   * Fix crash with unsupported MP4 files (NULL pointer dereference,
>     division by zero)
>   * CVE-2019-6956: ps_dec: sanitize iid_index before mixing
>   * CVE-2018-20196: sbr_fbt: sanitize sbr->M (should not exceed MAX_M)
>   * CVE-2018-20199, CVE-2018-20360: specrec: better handle unexpected
>     parametric stereo (PS)
>   * CVE-2018-20362, CVE-2018-19504, CVE-2018-20195, CVE-2018-20198,
>     CVE-2018-20358: syntax.c: check for syntax element inconsistencies
>   * CVE-2018-20194, CVE-2018-19503, CVE-2018-20197, CVE-2018-20357,
>     CVE-2018-20359, CVE-2018-20361: sbr_hfadj: sanitize frequency band
>     borders
>    [ Hugo Beauzée-Luyssen ]
>   * CVE-2019-15296, CVE-2018-19502: Fix a couple buffer overflows
>    [ Filip Roséen ]
>   * Prevent crash on SCE followed by CPE
>    [ Gianfranco Costamagna ]
>   * Fix linking with GCC 9 and "-Wl,--as-needed"
>    [ Fabian Greffrath ]
>   * Enable the frontend to be built reproducibly
> 
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/rootfiles/packages/faad2 | 3 +--
> lfs/faad2                       | 9 ++++++---
> 2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/config/rootfiles/packages/faad2 b/config/rootfiles/packages/faad2
> index 24e9ae30d..aa1d8a347 100644
> --- a/config/rootfiles/packages/faad2
> +++ b/config/rootfiles/packages/faad2
> @@ -1,14 +1,13 @@
> usr/bin/faad
> #usr/include/faad.h
> #usr/include/neaacdec.h
> -#usr/lib/libfaad.a
> #usr/lib/libfaad.la
> usr/lib/libfaad.so
> usr/lib/libfaad.so.2
> usr/lib/libfaad.so.2.0.0
> -#usr/lib/libfaad_drm.a
> #usr/lib/libfaad_drm.la
> usr/lib/libfaad_drm.so
> usr/lib/libfaad_drm.so.2
> usr/lib/libfaad_drm.so.2.0.0
> +#usr/lib/pkgconfig/faad2.pc
> #usr/share/man/man1/faad.1
> diff --git a/lfs/faad2 b/lfs/faad2
> index 5ec1541c1..b2c8218e1 100644
> --- a/lfs/faad2
> +++ b/lfs/faad2
> @@ -24,7 +24,7 @@
> 
> include Config
> 
> -VER        = 2.8.8
> +VER        = 2_10_0
> 
> THISAPP    = faad2-$(VER)
> DL_FILE    = $(THISAPP).tar.gz
> @@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
> DIR_APP    = $(DIR_SRC)/$(THISAPP)
> TARGET     = $(DIR_INFO)/$(THISAPP)
> PROG       = faad2
> -PAK_VER    = 2
> +PAK_VER    = 3
> 
> DEPS       =
> 
> @@ -44,7 +44,7 @@ objects = $(DL_FILE)
> 
> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> 
> -$(DL_FILE)_MD5 = 28f6116efdbe9378269f8a6221767d1f
> +$(DL_FILE)_MD5 = f948925a6763e30c53078f5af339d6cc
> 
> install : $(TARGET)
> 
> @@ -79,9 +79,12 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>   @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
>   $(UPDATE_AUTOMAKE)
> 
> +    cd $(DIR_APP) && autoupdate
> +    cd $(DIR_APP) && autoreconf -fvi
>   cd $(DIR_APP) && ./configure \
>       --prefix=/usr \
>       --enable-shared \
> +        --disable-static \
>       --with-mpeg4ip
> 
>   cd $(DIR_APP) && make $(MAKETUNING)
> -- 
> 2.32.0