From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Test of cleanup branch
Date: Thu, 01 Aug 2024 22:38:35 +0200
Message-ID: <16ddacf3-6330-446b-b5e0-de6d5c6fc968@ipfire.org>
In-Reply-To: <5be0d390-b9db-451d-b27a-403b0b455bee@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7094216188355584255=="
List-Id: <development.lists.ipfire.org>

--===============7094216188355584255==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

I did some more testing.

On 01/08/2024 19:09, Adolf Belka wrote:
> Hi Michael,
>
> More weird news.
>
> I created a fresh install of CU188 build ed2c97b7-dirty into a new vm.
>
> After installing it had the same issues as I had originally reported. I hav=
e taken lots of screenshots of all the issues I previously just wrote about.
>
> I then shutdown that CU188 IPFire and started back up the CU186 IPFire vm. =
That version then showed some of the issues I had seen in CU188. I cleared th=
e cache in my Firefox browser and CU186 went back to its normal look.
>
> I then stopped the CU186 and restarted CU188. It came up with all the issue=
s I originally reported. No matter what I tried I have not been able to get b=
ack to the version I had where the colour coding came back and the long entry=
 boxes were normal again. I tried clearing the browser cache several times bu=
t nothing changed.
>
> I am wondering if when I went to the CU188 version where the colour coding =
came back and the longer entry boxes disappeared that I was getting some cach=
e effects from when I had the CU186 version running.
>
> Anyway, either way I have been able to reproduce all my original reported i=
ssues by re-installing the CU188 iso and this time despite several reboots an=
d clearing browser caches the results has stayed the same.
>
> I have lots of screenshots of all the issues in case it does go away again.
>
> Maybe I will try doing a third fresh install of CU188 build ed2c97b7-dirty=
=C2=A0 and see if I get the same thing a third time. If yes, then my original=
 issues feedback today is the correct status and the intermediate result wher=
e some of the issues went away must be the anomaly, caused by some unknown se=
quence of steps that I have not been able to reproduce yet.
>
After running some other evaluation work with my CU186 vm system I then did a=
 fresh install of the CU188 iso. The mixture of colour coding of status on se=
rvices, IPSec & OpenVPN was present and the graph time period buttons were in=
 a vertical format at the bottom of the graph. I then cleared the browser cac=
he and the status colour coding disappeared and the time period buttons becam=
e a horizontal row. This was then in line with the final versions for the las=
t two installs of CU188 that I did.

It seems clear to me that the changes in the cleanup branch can be affected b=
y what is in the browser cache resulting in a mixture of the formats used fro=
m the cache and from the new coding. This could make the update a bit awkward=
 as it would depend on the browser cache being cleared, at least of all IPFIr=
e WUI pages.

> I will place the screenshots I have in my IPFire People home directory (pub=
lic section).
>
All screenshots placed in my public directory in my home directory.

Regards,

Adolf.

> Regards,
>
> Adolf.
>
>
> On 01/08/2024 17:45, Adolf Belka wrote:
>> Hi Michael,
>>
>> So the strikethrough of the existing text did not get applied in my previo=
us reply so the following is the feedback that applies now.
>>
>> All graphs have new selection buttons for Hour, Day, Weekly etc that are i=
n a vertical position below the graph. Pressing any of the buttons changes th=
e graph period being shown but the button does not change colour or anything =
to indicate it has been pressed. You have to look at the graph axis to figure=
 out which time period has been selected.
>>
>> Net-Traffic and ExtraHD have the same tables but instead of being centred =
on the page they are now on the Left Hand Side of the WUI page.
>>
>> On the Services page the first graph which should be titled Processes is l=
abelled 100%.
>>
>> On the System page the graphs have no name at all. On the vm I used they s=
hould have been labelled CPU and Load Avg.
>>
>> On the Pakfire page the list of available or installed addons do not show =
the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>
>> The vulnerabilities page has the left hand section now in black background=
 with white lettering and the right hand section of the table now has no colo=
ur coding. Everything is black lettering on a white background.
>>
>> The following menu items showed no change/issues except maybe for the grap=
h period selection buttons .
>> Backup
>> Shutdown
>> Credits
>> Mailservice
>> Memory
>> Media
>> Network External, Internal and Other
>> OpenVPN RW and N2N Statistics
>> WIO
>> Hardware graphs
>> Connections
>> Mdstat
>> DNS
>> Web Proxy
>> URL Filter
>> Update Accelerator
>> Edit Hosts
>> QOS
>> IP Address Blocklist
>> Location Block
>> IPTables
>> Firewall Groups
>> Firewall Options
>> Blue Access
>> Log Summary
>> Dynamic DNS
>> Proxy reports
>> Firewall logs
>> Firewall graphs - IP, Port & Country
>> IPS Logs
>> IP Address blocklist logs
>> OpenVPN RW logs
>> URL Filter Logs
>> System Logs
>> Captive portal
>> Connection Scheduler
>> Assign MAC Address
>> DHCP
>> DNS Forward
>> Static Routes
>> Wake on LAN
>> Time Server
>> Log Settings
>> Proxy Logs
>>
>> Regards,
>>
>> Adolf
>>
>>
>> On 01/08/2024 17:24, Adolf Belka wrote:
>>> Hi Michael,
>>>
>>> So I repeated a CU188 IPFire shutdown, start CU186 IPFire vm, shutdown it=
 down and restart the CU188 vm a few times. Nothing changed further so I am e=
diting my feedback below by striking through all my comments that no longer a=
pply. I have no idea what happened to cause what I experienced.
>>>
>>> Regards,
>>>
>>> Adolf
>>>
>>>
>>> On 01/08/2024 17:01, Adolf Belka wrote:
>>>> Hi Michael,
>>>>
>>>> Additional note written after all of the feedback below the dashed line =
was written. I did a shutdown of the vm with CU188 to check something in the =
CU186 vm then went back to the CU188 version and things had changed. Most of =
the longer boxes are no longer longer and don't overlap other elements. The m=
issing colours are back for IPSec, OpenVPN etc.
>>>>
>>>> The graph period selection previously was in a horizontal line under the=
 graph. Now it was still under the graph but it is now a vertical selection c=
hoice which can't have been intended as it takes far too much space. However =
the key thing is that rebooting seems to be making things change, which shoul=
dn't be happening. I have started to take screenshots of things to have some =
evidence.
>>>>
>>>> Attached is a screenshot showing the graph period selectors which are no=
w vertically positioned at the bottom of the graphs.
>>>>
>>>> Also attached is a screenshot of the pakfire page that is still missing =
the pak_ver numbers.
>>>>
>>>> I don't know what is going on here.
>>>>
>>>> ----------------------------------------------
>>>>
>>>> Okay, here is the feedback from reviewing a vm that actually included th=
e cleanup branch changes.
>>>>
>>>> The home and ssh items look better with the change. They now use alterna=
ting shades of grey to highlight each line.
>>>>
>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that sho=
w in red when selected. This looks better. The default is the Day selection b=
ut when you start with a graph it does not indicate that it is using the Day =
option, ie all buttons are showing grey.
>>>>
>>>> Net-Traffic and ExtraHD have the same tables but instead of being centre=
d on the page they are now on the Left Hand Side of the WUI page.
>>>>
>>>> The Zone Config page looks much busier now. Previously the dropdown box =
for native or vlan selection was next to the vlan id box and the space was go=
od enough for that. Now they are placed one above the other, so wider, which =
is not needed but they now fill the whole space of the section before the nex=
t nic interface starts. I think the previous version looked clearer.
>>>>
>>>> The IPS page and the Services page no longer show the red or green backg=
round for running or stopped. You still see the words but they are now in whi=
te on a light grey background or white on a slightly darker grey.
>>>>
>>>> On the Services page the first graph which should be titled Processes is=
 labelled 100%.
>>>>
>>>> On the System page the graphs have no name at all. On the vm I used they=
 should have been labelled CPU and Load Avg.
>>>>
>>>> On the Pakfire page the list of available or installed addons do not sho=
w the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>
>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colour=
s for the connection status.
>>>>
>>>> On the Firewall Rules page the table has no colours for Accept, Reject o=
r Drop for any of the rules. The alternate grey shading has got mixed up as i=
t is considering that if there is a remark line for a firewall rule that is a=
 separate line and the grey shading has to be changed. Definitely not right. =
Some of the Destinations have not had the right colour code applied for the z=
one colour - left grey. The boxes giving the policy applied for each firewall=
 section are not colour coded for Allow or Blocked.
>>>>
>>>> On the actual firewall creation page, there are longer boxes that overla=
p labels or other elements. There is no colour in the Drop, Reject, Accept se=
lection box just one shade of grey.
>>>>
>>>> The vulnerabilities page has the left hand section now in black backgrou=
nd with white lettering. Different but probably okay. After the reboot the Ri=
ght Hand Side of the table now has no colour coding. Everything is black lett=
ering on a white background. Screenshot of how this is now is attached.
>>>>
>>>> The following menu items showed longer entry boxes that overlap labels o=
r other elements
>>>> DHCP
>>>> DNS Forward
>>>> Static Routes
>>>> Wake on LAN
>>>> Time Server
>>>> Log Settings
>>>> Proxy Logs
>>>>
>>>>
>>>> The following menu items showed longer entry boxes that did not overlap =
other elements but you end up with a much longer box length than is needed fo=
r a day number for example
>>>> Firewall Groups
>>>> Firewall Options
>>>> Blue Access
>>>> Log Summary
>>>> Dynamic DNS
>>>> Proxy reports
>>>> Firewall logs
>>>> Firewall graphs - IP, Port & Country
>>>> IPS Logs
>>>> IP Address blocklist logs
>>>> OpenVPN RW logs
>>>> URL Filter Logs
>>>> System Logs
>>>> Captive portal
>>>> Connection Scheduler
>>>> Assign MAC Address
>>>>
>>>>
>>>> The following menu items showed no change/issues except maybe for the gr=
aph period selection buttons .
>>>> Backup
>>>> Shutdown
>>>> Credits
>>>> Mailservice
>>>> Memory
>>>> Media
>>>> Network External, Internal and Other
>>>> OpenVPN RW and N2N Statistics
>>>> WIO
>>>> Hardware graphs
>>>> Connections
>>>> Mdstat
>>>> DNS
>>>> Web Proxy
>>>> URL Filter
>>>> Update Accelerator
>>>> Edit Hosts
>>>> QOS
>>>> IP Address Blocklist
>>>> Location Block
>>>> IPTables
>>>>
>>>> I am really sorry for giving false hope that the cleanup branch had gone=
 really well.
>>>>
>>>> Regards,
>>>>
>>>> Adolf.
>>>>
>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>> Hi Michael,
>>>>>
>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>> Hi Michael,
>>>>>>
>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>> Hello Adolf,
>>>>>>>
>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>
>>>>> Maybe I got back too quickly!!
>>>>>
>>>>> I have just done a build with next for a bugfix patch and installed it =
into my vm and the pages look quite different with some things missing, like =
the green and red colours for if services are running or not and some graph t=
itles are incorrect.
>>>>>
>>>>> I took the iso from the latest directory in the nightly build but it lo=
oks like it was still linked to the previous version when I downloaded it as =
the b2 sum is for build 6460dbbf from the day before.
>>>>>
>>>>> Downloading the iso today from the latest directory gives me the build =
ed2c97b7.
>>>>>
>>>>> I am going to install that version now but I suspect it will show the s=
ame as I found with my build.
>>>>>
>>>>> So it looks like my original review was based on the version before the=
 cleanup branch changes were included.
>>>>>
>>>>> I will come back with new feedback of what I find from the latest branc=
h that I have now downloaded.
>>>>>
>>>>> Sorry. In future maybe I should wait till the following day, or downloa=
d from the build named directory instead of the directory named latest.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Adolf
>>>>>
>>>>>>> I suppose this also means that the ISO in the next branch boots just =
fine, too?
>>>>>>
>>>>>> Yes, that is correct. I used the iso from the nightly next latest dire=
ctory. No problems with the install at all.
>>>>>> This tested out raid and all 4 interfaces.
>>>>>>
>>>>>> Regards,
>>>>>> Adolf.
>>>>>>
>>>>>>>
>>>>>>> Best,
>>>>>>> -Michael
>>>>>>>
>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wro=
te:
>>>>>>>>
>>>>>>>> Hi Michael,
>>>>>>>>
>>>>>>>> I installed CU188 from the nightly onto a vm system and looked thoug=
h all the WUI pages and everything looked fine.
>>>>>>>>
>>>>>>>> I then restored a CU187 backup from my testing and then checked the =
OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for t=
hat all worked with no problems.
>>>>>>>>
>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, =
DNS ...
>>>>>>>>
>>>>>>>> Everything I have looked at shows no impact from the cleanup branch =
changes. It looks good to me.
>>>>>>>>
>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>> Adolf.
>>>>>>>>
>>>>>>>

--===============7094216188355584255==--