From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Cuka <stephen@firemypi.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Remove space after every 80 characters in WebGUI
 "Logs/System Logs".
Date: Mon, 05 Aug 2024 18:47:53 +0000
Message-ID: <172288367319.1831417.3462292333355828565@mail02.haj.ipfire.org>
In-Reply-To: <8c2b7c07-d2ec-4b43-a852-b606759d34bc@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8804592495069335506=="
List-Id: <development.lists.ipfire.org>

--===============8804592495069335506==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Adolf,

Thanks for your help on this.

I left the original code lines in place for context.  They're not really nece=
ssary.  If it's better, I can remove them and resubmit the patch.

For the=20

my $d =3D $2.': '.$data;

suggestion, there is some special processing for the display for the RED sect=
ion logs.

        # correct the cut position, just when section=3DRED
        if (($cgiparams{'SECTION'} eq 'red' ) && ($sec =3D~ /(kernel:)(.*)/))=
 {
            $sec =3D 'kernel';
            $data =3D $2.': '.$data;
        }

Using 'my $d =3D $2. ': ' .$data;' for everything would add the timestamp to =
the front of the log text displayed for all sections.

I'm not sure if the special processing for $data for RED is necessary.  I thi=
nk that the point of the 'if' statement is to clean up the Section display fo=
r entries from 'kernel: ippp\d' and 'kernel: isdn.*' matches for RED, but I d=
on't know why adding the timestamp to the front of data would be desirable in=
 that specific case.  I don't have any log entries to reference for that thou=
gh.

Thanks,
Stephen

--===============8804592495069335506==--