public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Cc: Vincent Li <vincent.mc.li@gmail.com>
Subject: Re: [PATCH] cdrom: Use uppercase EFI boot filename on LoongArch
Date: Wed, 18 Nov 2026 14:41:23 +0000	[thread overview]
Message-ID: <1795012883.4063288.reply@ipfire.org> (raw)
In-Reply-To: <20261106053659.1881811-1-vincent.mc.li@gmail.com>

Hello Vincent,

Thank you for the patch and for testing it on real hardware. I have
merged it, and added a small follow-up on top.

I did not want to special-case LoongArch, because the uppercase name is
the correct one everywhere. ISO9660 itself only knows uppercase names.
The lowercase name only exists through the Rock Ridge/Joliet extensions,
and firmware that reads those compares names exactly. The UEFI spec
calls the fallback loader \EFI\BOOT\BOOT<ARCH>.EFI. Most firmware is
case-insensitive and does not care, which is why only your Loongson
board noticed. lfs/flash-images already uses the uppercase name, so the
ISO was the odd one out.

So the follow-up drops the ifeq and uses the uppercase name on all
architectures. EFI_ARCH is "x64" on x86, so a plain BOOT$(EFI_ARCH).EFI
would still have given BOOTx64.EFI. The name is now run through tr to
get BOOTX64.EFI.

Your commit is kept as it was, with you as the author, so the history
shows where the change came from. Thanks for tracking this down. Would
you mind testing the final result on the M700S once more?

Best regards,
-Michael


      reply	other threads:[~2026-11-18 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  5:36 Vincent Li
2026-11-18 14:41 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1795012883.4063288.reply@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    --cc=vincent.mc.li@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox