From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Kernel: Disable support for RPC dprintk debugging
Date: Mon, 13 Jun 2022 14:31:17 +0100
Message-ID: <17CF6D67-F42F-416A-A581-5C72199D9165@ipfire.org>
In-Reply-To: <2e7c4167-0d0f-3020-573a-843a262e2447@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5576670006897433554=="
List-Id: <development.lists.ipfire.org>

--===============5576670006897433554==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 11 Jun 2022, at 19:47, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> This is solely needed for debugging of NFS issues. Due to the attack
> surface it introduces, grsecurity recommends to disable it; as we do not
> have a strict necessity for this feature, it is best to follow that
> recommendation for security reasons.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> config/kernel/kernel.config.aarch64-ipfire | 3 +--
> config/kernel/kernel.config.armv6l-ipfire  | 3 +--
> config/kernel/kernel.config.riscv64-ipfire | 3 +--
> config/kernel/kernel.config.x86_64-ipfire  | 3 +--
> 4 files changed, 4 insertions(+), 8 deletions(-)
>=20
> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/ker=
nel.config.aarch64-ipfire
> index 6dfeae595..4cbb3604e 100644
> --- a/config/kernel/kernel.config.aarch64-ipfire
> +++ b/config/kernel/kernel.config.aarch64-ipfire
> @@ -7433,7 +7433,6 @@ CONFIG_NFS_V4_SECURITY_LABEL=3Dy
> CONFIG_NFS_FSCACHE=3Dy
> # CONFIG_NFS_USE_LEGACY_DNS is not set
> CONFIG_NFS_USE_KERNEL_DNS=3Dy
> -CONFIG_NFS_DEBUG=3Dy
> CONFIG_NFS_DISABLE_UDP_SUPPORT=3Dy
> # CONFIG_NFS_V4_2_READ_PLUS is not set
> CONFIG_NFSD=3Dm
> @@ -7457,7 +7456,7 @@ CONFIG_SUNRPC_GSS=3Dm
> CONFIG_SUNRPC_BACKCHANNEL=3Dy
> CONFIG_RPCSEC_GSS_KRB5=3Dm
> # CONFIG_SUNRPC_DISABLE_INSECURE_ENCTYPES is not set
> -CONFIG_SUNRPC_DEBUG=3Dy
> +# CONFIG_SUNRPC_DEBUG is not set
> # CONFIG_CEPH_FS is not set
> CONFIG_CIFS=3Dm
> # CONFIG_CIFS_STATS2 is not set
> diff --git a/config/kernel/kernel.config.armv6l-ipfire b/config/kernel/kern=
el.config.armv6l-ipfire
> index 1bb745a87..6347e2af2 100644
> --- a/config/kernel/kernel.config.armv6l-ipfire
> +++ b/config/kernel/kernel.config.armv6l-ipfire
> @@ -7439,7 +7439,6 @@ CONFIG_NFS_V4_SECURITY_LABEL=3Dy
> CONFIG_NFS_FSCACHE=3Dy
> # CONFIG_NFS_USE_LEGACY_DNS is not set
> CONFIG_NFS_USE_KERNEL_DNS=3Dy
> -CONFIG_NFS_DEBUG=3Dy
> CONFIG_NFS_DISABLE_UDP_SUPPORT=3Dy
> # CONFIG_NFS_V4_2_READ_PLUS is not set
> CONFIG_NFSD=3Dm
> @@ -7463,7 +7462,7 @@ CONFIG_SUNRPC_GSS=3Dm
> CONFIG_SUNRPC_BACKCHANNEL=3Dy
> CONFIG_RPCSEC_GSS_KRB5=3Dm
> # CONFIG_SUNRPC_DISABLE_INSECURE_ENCTYPES is not set
> -CONFIG_SUNRPC_DEBUG=3Dy
> +# CONFIG_SUNRPC_DEBUG is not set
> # CONFIG_CEPH_FS is not set
> CONFIG_CIFS=3Dm
> # CONFIG_CIFS_STATS2 is not set
> diff --git a/config/kernel/kernel.config.riscv64-ipfire b/config/kernel/ker=
nel.config.riscv64-ipfire
> index 2d1fdbd28..60aee16d4 100644
> --- a/config/kernel/kernel.config.riscv64-ipfire
> +++ b/config/kernel/kernel.config.riscv64-ipfire
> @@ -6071,7 +6071,6 @@ CONFIG_NFS_V4_SECURITY_LABEL=3Dy
> CONFIG_NFS_FSCACHE=3Dy
> # CONFIG_NFS_USE_LEGACY_DNS is not set
> CONFIG_NFS_USE_KERNEL_DNS=3Dy
> -CONFIG_NFS_DEBUG=3Dy
> CONFIG_NFS_DISABLE_UDP_SUPPORT=3Dy
> CONFIG_NFS_V4_2_READ_PLUS=3Dy
> CONFIG_NFSD=3Dm
> @@ -6095,7 +6094,7 @@ CONFIG_SUNRPC_GSS=3Dm
> CONFIG_SUNRPC_BACKCHANNEL=3Dy
> CONFIG_RPCSEC_GSS_KRB5=3Dm
> # CONFIG_SUNRPC_DISABLE_INSECURE_ENCTYPES is not set
> -CONFIG_SUNRPC_DEBUG=3Dy
> +# CONFIG_SUNRPC_DEBUG is not set
> # CONFIG_CEPH_FS is not set
> CONFIG_CIFS=3Dm
> # CONFIG_CIFS_STATS2 is not set
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kern=
el.config.x86_64-ipfire
> index b84698235..f7b03831d 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -6847,7 +6847,6 @@ CONFIG_NFS_V4_SECURITY_LABEL=3Dy
> CONFIG_NFS_FSCACHE=3Dy
> # CONFIG_NFS_USE_LEGACY_DNS is not set
> CONFIG_NFS_USE_KERNEL_DNS=3Dy
> -CONFIG_NFS_DEBUG=3Dy
> CONFIG_NFS_DISABLE_UDP_SUPPORT=3Dy
> CONFIG_NFS_V4_2_READ_PLUS=3Dy
> CONFIG_NFSD=3Dm
> @@ -6871,7 +6870,7 @@ CONFIG_SUNRPC_GSS=3Dm
> CONFIG_SUNRPC_BACKCHANNEL=3Dy
> CONFIG_RPCSEC_GSS_KRB5=3Dm
> # CONFIG_SUNRPC_DISABLE_INSECURE_ENCTYPES is not set
> -CONFIG_SUNRPC_DEBUG=3Dy
> +# CONFIG_SUNRPC_DEBUG is not set
> # CONFIG_CEPH_FS is not set
> CONFIG_CIFS=3Dm
> # CONFIG_CIFS_STATS2 is not set
> --=20
> 2.35.3


--===============5576670006897433554==--