From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] icmp-types file does not have to be executable
Date: Fri, 14 May 2021 17:55:29 +0200
Message-ID: <19074e69-dc1e-8b23-a8b4-c7ea91eee07c@ipfire.org>
In-Reply-To: <4da0f7d9-7ba1-8ce6-7d21-724f4ed6d0f1@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7278642409804040495=="
List-Id: <development.lists.ipfire.org>

--===============7278642409804040495==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

just for the sake of completeness: Would you mind shipping this change in Cor=
e Update 157?

A

> chmod -x /var/ipfire/fwhosts/icmp-types

in the upgrade script should be sufficient, I guess.

Thanks, and best regards,
Peter M=C3=BCller


> This file does not contain any executable code, hence we should not set
> its permission to be executable.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
>  config/fwhosts/icmp-types | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 =3D> 100644 config/fwhosts/icmp-types
>=20
> diff --git a/config/fwhosts/icmp-types b/config/fwhosts/icmp-types
> old mode 100755
> new mode 100644
>=20

--===============7278642409804040495==--