* [PATCH] icmp-types file does not have to be executable
@ 2021-04-22 15:47 Peter Müller
2021-05-14 15:55 ` Peter Müller
0 siblings, 1 reply; 2+ messages in thread
From: Peter Müller @ 2021-04-22 15:47 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
This file does not contain any executable code, hence we should not set
its permission to be executable.
Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
config/fwhosts/icmp-types | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 config/fwhosts/icmp-types
diff --git a/config/fwhosts/icmp-types b/config/fwhosts/icmp-types
old mode 100755
new mode 100644
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] icmp-types file does not have to be executable
2021-04-22 15:47 [PATCH] icmp-types file does not have to be executable Peter Müller
@ 2021-05-14 15:55 ` Peter Müller
0 siblings, 0 replies; 2+ messages in thread
From: Peter Müller @ 2021-05-14 15:55 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
Hello Michael,
just for the sake of completeness: Would you mind shipping this change in Core Update 157?
A
> chmod -x /var/ipfire/fwhosts/icmp-types
in the upgrade script should be sufficient, I guess.
Thanks, and best regards,
Peter Müller
> This file does not contain any executable code, hence we should not set
> its permission to be executable.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/fwhosts/icmp-types | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> mode change 100755 => 100644 config/fwhosts/icmp-types
>
> diff --git a/config/fwhosts/icmp-types b/config/fwhosts/icmp-types
> old mode 100755
> new mode 100644
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-14 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 15:47 [PATCH] icmp-types file does not have to be executable Peter Müller
2021-05-14 15:55 ` Peter Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox