From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG12301: Iptables =?utf-8?q?=E2=80=9Chost/network_?=
 =?utf-8?b?4oCYbm9uZeKAmSBub3QgZm91bmTigJ0=?=
Date: Mon, 12 Apr 2021 11:18:13 +0100
Message-ID: <191AC389-53C6-4F39-9C62-B7F90266B415@ipfire.org>
In-Reply-To: <20210412060545.10016-1-alexander.marx@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4330097386428071340=="
List-Id: <development.lists.ipfire.org>

--===============4330097386428071340==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

> On 12 Apr 2021, at 07:05, Alexander Marx <alexander.marx(a)ipfire.org> wrot=
e:
>=20
> Fixes: #12301
>=20
> When using hosts with MAC-addresses in a hostgroup,
> the rule won't be generated if those hosts are selected as target.
> There is a hint but due to a wrong hashparameter the hint was not shown.
>=20
> With this patch the hint is shown again.
> Additionally the rule is skipped when rules.pl creates rules.
>=20
> There are no bootmessages with failed target "none" anymore.
> ---
> config/firewall/firewall-lib.pl | 4 ++--
> html/cgi-bin/firewall.cgi       | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/config/firewall/firewall-lib.pl b/config/firewall/firewall-lib=
.pl
> index bc0b30ca5..e7ec30ae0 100644
> --- a/config/firewall/firewall-lib.pl
> +++ b/config/firewall/firewall-lib.pl
> @@ -2,7 +2,7 @@
> ###########################################################################=
####
> #                                                                          =
   #
> # IPFire.org - A linux based firewall                                      =
   #
> -# Copyright (C) 2013 Alexander Marx <amarx(a)ipfire.org>                  =
      #
> +# Copyright (C) 2021 Alexander Marx <amarx(a)ipfire.org>                  =
      #
> #                                                                          =
   #
> # This program is free software: you can redistribute it and/or modify     =
   #
> # it under the terms of the GNU General Public License as published by     =
   #
> @@ -315,7 +315,7 @@ sub get_addresses
> 		foreach my $grp (sort {$a <=3D> $b} keys %customgrp) {
> 			if ($customgrp{$grp}[0] eq $value) {
> 				my @address =3D &get_address($customgrp{$grp}[3], $customgrp{$grp}[2], =
$type);
> -
> +				next if ($address[0][0] eq 'none');

A comment for these rather obscure things would not hurt, but technically I a=
gree with how this is solved.



> 				if (@address) {
> 					push(@addresses, @address);
> 				}
> diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
> index 1483e779f..b0851dd3e 100644
> --- a/html/cgi-bin/firewall.cgi
> +++ b/html/cgi-bin/firewall.cgi
> @@ -592,7 +592,7 @@ sub checktarget
> 		&General::readhasharray("$confighost", \%customhost);
> 		foreach my $grpkey (sort keys %customgrp){
> 			foreach my $hostkey (sort keys %customhost){
> -				if ($customgrp{$grpkey}[2] eq $customhost{$hostkey}[0] && $customgrp{$=
grpkey}[2] eq $fwdfwsettings{$fwdfwsettings{'grp2'}} && $customhost{$hostkey}=
[1] eq 'mac'){
> +				if ($customgrp{$grpkey}[2] eq $customhost{$hostkey}[0] && $customgrp{$=
grpkey}[0] eq $fwdfwsettings{$fwdfwsettings{'grp2'}} && $customhost{$hostkey}=
[1] eq 'mac'){

What has changed here?

> 					$hint=3D$Lang::tr{'fwdfw hint mac'};
> 					return $hint;
> 				}
> =E2=80=94=20
> 2.25.1
>=20

Best,
-Michael


--===============4330097386428071340==--