From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Roevens To: development@lists.ipfire.org Subject: Re: [PATCH v2 00/10] pakfire: remove dup. code + seperate ui/logic Date: Fri, 29 Jul 2022 22:11:51 +0200 Message-ID: <191b0caddbf3676709f8c1bdf296e771766f9631.camel@sicho.home> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8114392558100708499==" List-Id: --===============8114392558100708499== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Peter Peter M=C3=BCller schreef op do 28-07-2022 om 13:51 [+0000]: > Hello Robin, >=20 > thanks for your mail, the second version of this patchset, and > marking the first > version as "superseded" in Patchwork. :-) >=20 > I just merged the patchset into "next", so everyone running on the > "unstable" tree > can see the changes and test them. Commit > 3543c24f41027c6e4437b8d1b3d3ca75d47ed3c9 > should ship all the files you changed, please let me know in case I > forgot anything. I think, aside from de localization files, you have them all. I'm not completely sure what this rootfile is you modified here? Are those all files that differ since last core update ? But I asume lang files are then handled somewhere else ? Robin >=20 > All the best, > Peter M=C3=BCller >=20 >=20 > > Hi all > >=20 > > As promised a revision of this patchset by the end of July. > > Also fixing bug #12868, both in patch 01 (installed: yes/no output) > > and=20 > > patch 06 (don't trow error on valid '--no-color' option). > >=20 > > This is quite a large patchset on delicate code which was discussed > > upon > > previous submission, but that was almost half a year ago. So I will > > try > > to link references to discussions on my previous submission where > > appropriate to refresh some memories :-). > >=20 > > What was changed since last submission; implementing/fixing=20 > > Michael's remarks/concerns: > > - Patch 01: Added translations as requested here:=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > https://lists.ipfire.org/pipermail/development/2022-March/012782.html > > - Patch 02: New patch translating WUI header/footer text > > - Patch 03: (previously patch 02) was not changed > > - Patch 04: (previously patch 03) replaced a forgotten > > fetchfile/move > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 combo = by new getmetafile function > > - Previous patch 04 was removed as the function > > coreupdate_available turned out no > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 longer= used.=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 See: > > https://lists.ipfire.org/pipermail/development/2022-March/012884.html > > - Patch 05: Replaced seq shell command by perl seq-method, > > consistent > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 use of= 'Core-Update' as requested here:=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > https://lists.ipfire.org/pipermail/development/2022-March/012787.html > > - Patch 06: Added exitcode to pakfire list as requested here:=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > https://lists.ipfire.org/pipermail/development/2022-March/012787.html > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Also e= xit with error when an unknown parameter is > > passed to > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pakfir= e list > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Added = a small fix (in my opinion): log termination of > > pakfire=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 inside= END block > > - Patch 07: Removed function coreupdate_available as it was > > concluded > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 that i= t was no longer needed (see again:=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > https://lists.ipfire.org/pipermail/development/2022-March/012884.html > > ) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Added = meaningfull status exit code as remarked here: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > https://lists.ipfire.org/pipermail/development/2022-March/012788.html > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Split = previous patch 07 pakfire.cgi changes in new > > patch 08: > > - Patch 08: New patch, previously part of patch 07 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Fixed = localization as pointed out here: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > https://lists.ipfire.org/pipermail/development/2022-March/012788.html > > - Patch 09: (previously patch 08) Split previous patch 08 into > > patch 09 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 adding= 'getmetadata' function and 'pakfire info' and > > patch 10 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 implem= enting the new 'getmetadata' in service.cgi. > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Show c= lean warning message when no packages are found > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 with r= equested pakfire list filter > > - Patch 10: (previously part of patch 08) Removed hardcoded > > exclusions > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 in ser= vices.cgi as pointed out here: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > https://lists.ipfire.org/pipermail/development/2022-March/012789.html > > Previous patch 09 was dropped from this patchset as there turned > > out to > > be major problems with it and should be rethinked as pointed out > > here: > > https://lists.ipfire.org/pipermail/development/2022-March/012856.html > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=20 > >=20 > > I think I have tested this all throughly but as these are quite > > interusive > > changes to the pakfire core workings; Please do not trust my > > testing and test=20 > > these patches yourselves during review. I would not want to carry > > the > > responibilities of breaking pakfire alone :-) > >=20 > > Regards > > Robin > >=20 > >=20 > >=20 > >=20 >=20 --=20 Dit bericht is gescanned op virussen en andere gevaarlijke inhoud door MailScanner en lijkt schoon te zijn. --===============8114392558100708499==--