From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4b1tQj2qrRz3028 for ; Tue, 20 May 2025 11:59:57 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4b1tQf05Zlz2xMK for ; Tue, 20 May 2025 11:59:54 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4b1tQc52gFzGg; Tue, 20 May 2025 11:59:52 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1747742393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MUnxJU4mV9ZZ+P7KO/ZduQhHcFoP76wc4MW9t1tBS9s=; b=rcvXe398UARtC85KdudPI7oryQFN+j1zQCNAe1nwSlmqv+4HHW04pjII8v9ba86pUBXsG4 Z7a7IFAGY55OSyCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1747742393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MUnxJU4mV9ZZ+P7KO/ZduQhHcFoP76wc4MW9t1tBS9s=; b=kAALRFo0fLM0GyrWT0EZHWWJeVLMzQ055UKF/BXswgPfx/pkQGBxhyuizxDaXZxVRnbcZ6 ZMnUjHbsHN90IQ5NGMi4WkW+8dgvwDoS39jk33AMqiyzzY7WKVhBaqg87c65WnuBzvXTqK g9naWktkDqAXoQjIGcjFqQp6VZlVd/EL+sNlKU+o0Ncwq9gszWdm4992z5RwX5wKRXLYpF 96FqbHjkJlJKTvR5LysjL6L5qr/90upRTuDjujPPM5MwwKn9jq0u9CZg/C17Us85D9MtFu 8Z3YvoNWQkFrHenPwxvtsJ/rzQQkMIWX8CFm2tfuXDreeVbIXjcc0c83/A88ww== From: Stefan Schantl To: Adolf Belka , CC: Adam G Date: Tue, 20 May 2025 13:59:51 +0200 Message-ID: <196ed907ad8.27e7.cac9d3ffac9e24d09d20af05166fd73b@ipfire.org> In-Reply-To: <20250520105739.7264-1-adolf.belka@ipfire.org> References: <20250520105739.7264-1-adolf.belka@ipfire.org> Subject: Re: [PATCH] http-client-functions.pl: Fixes bug13852 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="196ed907d6457b727e72090671" This is a multi-part message in MIME format. --196ed907d6457b727e72090671 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit Good catch. Thank you. Acked-by: Stefan Schantl Am 20. Mai 2025 12:57:48 schrieb Adolf Belka : > Suggested-by: Adam G > Fixes: bug13852 > Tested-by: Adolf Belka > Tested-by: Adam G > Signed-off-by: Adolf Belka > --- > config/cfgroot/http-client-functions.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/cfgroot/http-client-functions.pl > b/config/cfgroot/http-client-functions.pl > index 51687ffde..7f7675bbf 100644 > --- a/config/cfgroot/http-client-functions.pl > +++ b/config/cfgroot/http-client-functions.pl > @@ -178,7 +178,7 @@ sub downloader (%) { > # Check if an file for etags has been given. > if ($etags_file) { > # Read-in Etags file for known Etags if the file is present. > - &readhash("$etags_file", \%etags) if (-f $etags_file); > + &General::readhash("$etags_file", \%etags) if (-f $etags_file); > > # Check if an Etag for the requested file is stored. > if ($etags{$etagprefix}) { > -- > 2.49.0 --196ed907d6457b727e72090671 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Good catch.

Thank you.

Acked-b= y: Stefan Schantl <stefan.schantl@ipfire.org>
=
Am 20. Mai 2025 12:57:48 schrieb Adolf Belka <adolf.be= lka@ipfire.org>:

Suggested-by: Adam G <ag@ipfire.org>
Fixes: bug13852
Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Tested-by: Adam G <ag@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>=
---
 config/cfgroot/http-client-functions.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/cfgroot/http-client-functions.pl b/co= nfig/cfgroot/http-client-functions.pl
index 51687ffde..7f7675bbf 100644
--- a/config/cfgroot/http-client-functions.pl
+++ b/config/cfgroot/http-client-functions.pl
@@ -178,7 +178,7 @@ sub downloader (%) {
 =09# Check if an file for etags has been given.
 =09if ($etags_file) {
 =09=09# Read-in Etags file for known Etags if the f= ile is present.
-=09=09&readhash("$etags_file", \%etags) if (-f $etag= s_file);
+=09=09&General::readhash("$etags_file", \%etags) if = (-f $etags_file);
 
 =09=09# Check if an Etag for the requested file is = stored.
 =09=09if ($etags{$etagprefix}) {
-- 
2.49.0

--196ed907d6457b727e72090671--