From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH 3/3] perl-Net-SMTP-SSL: Update to 1.04 Date: Mon, 22 Mar 2021 12:52:12 +0100 Message-ID: <199c2e0a-d817-2e88-6705-de6d4e7c74d9@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8937063641420022581==" List-Id: --===============8937063641420022581== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 22/03/2021 12:19, Michael Tremer wrote: > Hello, >=20 > I merged it, because we need Git for development purposes. >=20 > I am writing CGI scripts on the systems and commit small changes. Copying f= iles back and forth would be error-prone and waste time. That makes it clear what git is being used for. I am definitely=20 following the copying files back and forth approach when I am working on=20 some of the bugs and have found sometimes that I have had to start all=20 over again because of errors. Makes sense to use git for managing that=20 for the development work. >=20 > I do not think that Git needs documentation on the wiki. There is some stuf= f in the development section. Understand. It's not intended for the general user but for development work. >=20 > If we can replace this module by a newer version, that would definitely hel= p in the future :) I will see if I can give it a go but that will probably need to be=20 tested well by you and the other devs to make sure it still does what=20 you need it to do. Regards, Adolf. >=20 > -Michael >=20 >> On 22 Mar 2021, at 07:44, Adolf Belka wrote: >> >> Hi All, >> >> When updating this dependency of git I saw that it was now deprecated. I h= ad a look at the replacement library and while I could create it as a new add= on, it was not clear to me if just defining it as a dependency of git would m= ake git correctly use it. >> >> I am also not sure why anyone would want to run git on a firewall. This ad= don is not listed in the wiki. >> >> I am therefore not sure if this patch set should be merged or if it should= be updated with the new library (and how) or if git should still be left in = IPFire as an addon and hence this library. >> >> I am open to whatever decision you think is appropriate for this patch set. >> >> Regards, >> Adolf. >> >> On 22/03/2021 08:33, Adolf Belka wrote: >>> - Update from 1.02 to 1.04 >>> - Update of rootfile not required >>> - This is a dependency of git addon package >>> - Changelog >>> 1.04 2016-10-09 >>> - mark this library deprecated, suggest newer Net::SMTP instead >>> 1.03 2015-06-20 >>> - $net_smtp_ssl->isa('Net::SMTP') is now true >>> Signed-off-by: Adolf Belka >>> --- >>> lfs/perl-Net-SMTP-SSL | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> diff --git a/lfs/perl-Net-SMTP-SSL b/lfs/perl-Net-SMTP-SSL >>> index 90e8a2260..2bb00a808 100644 >>> --- a/lfs/perl-Net-SMTP-SSL >>> +++ b/lfs/perl-Net-SMTP-SSL >>> @@ -24,7 +24,7 @@ >>> include Config >>> -VER =3D 1.02 >>> +VER =3D 1.04 >>> THISAPP =3D Net-SMTP-SSL-$(VER) >>> DL_FILE =3D ${THISAPP}.tar.gz >>> @@ -33,7 +33,7 @@ DIR_APP =3D $(DIR_SRC)/$(THISAPP) >>> TARGET =3D $(DIR_INFO)/$(THISAPP) >>> PROG =3D perl-Net-SMTP-SSL >>> DEPS =3D >>> -PAK_VER =3D 2 >>> +PAK_VER =3D 3 >>> #####################################################################= ########## >>> # Top-level Rules >>> @@ -43,7 +43,7 @@ objects =3D $(DL_FILE) >>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >>> -$(DL_FILE)_MD5 =3D e67b4d842a51b9a453aeeaeed45fb8e1 >>> +$(DL_FILE)_MD5 =3D 62b49c961043898b43b041dafbc1b389 >>> install : $(TARGET) >>> =20 >> >> --=20 >> Sent from my laptop >=20 --=20 Sent from my laptop --===============8937063641420022581==--