From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG11695: Adding/editing rules with preset broken
Date: Thu, 15 Jul 2021 18:07:07 +0200 [thread overview]
Message-ID: <19c60c442281a23fa55fdd47e213dd649305d09a.camel@ipfire.org> (raw)
In-Reply-To: <1527164764-17533-1-git-send-email-alexander.marx@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
Hello List,
as already described in the bug entry on bugzilla
(https://bugzilla.ipfire.org/show_bug.cgi?id=11695) I'm unable to
reproduce the origin bug anymore.
As I discovered in the GIT history this patch never has been merged and
because the bug does not exist anymore this patch is not longer
required.
Best regards,
-Stefan
> added another check to fill same ports in source and destination when
> a custom service is selected.
>
> Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> Reported-by: erik(a)vanlinsteeict.nl
> ---
> html/cgi-bin/firewall.cgi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
> index 499f279..d17afab 100644
> --- a/html/cgi-bin/firewall.cgi
> +++ b/html/cgi-bin/firewall.cgi
> @@ -757,6 +757,7 @@ sub checkrule
> }
> }
> if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} eq
> ''){$fwdfwsettings{'dnatport'}=$custsrvport;}
> + if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'grp3'} eq
> 'cust_srv'){$fwdfwsettings{'dnatport'}=$custsrvport;}
> }
> #check if DNAT port is multiple
> if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} ne ''){
prev parent reply other threads:[~2021-07-15 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 12:26 Alexander Marx
2018-05-24 14:47 ` Michael Tremer
2021-07-15 16:07 ` Stefan Schantl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c60c442281a23fa55fdd47e213dd649305d09a.camel@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox