From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] BUG11695: Adding/editing rules with preset broken
Date: Thu, 15 Jul 2021 18:07:07 +0200
Message-ID: <19c60c442281a23fa55fdd47e213dd649305d09a.camel@ipfire.org>
In-Reply-To: <1527164764-17533-1-git-send-email-alexander.marx@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2010478481833653294=="
List-Id: <development.lists.ipfire.org>

--===============2010478481833653294==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello List,

as already described in the bug entry on bugzilla
(https://bugzilla.ipfire.org/show_bug.cgi?id=3D11695) I'm unable to
reproduce the origin bug anymore.

As I discovered in the GIT history this patch never has been merged and
because the bug does not exist anymore this patch is not longer
required.

Best regards,

-Stefan
> added another check to fill same ports in source and destination when
> a custom service is selected.
>=20
> Signed-off-by: Alexander Marx <alexander.marx(a)ipfire.org>
> Reported-by: erik(a)vanlinsteeict.nl
> ---
> =C2=A0html/cgi-bin/firewall.cgi | 1 +
> =C2=A01 file changed, 1 insertion(+)
>=20
> diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
> index 499f279..d17afab 100644
> --- a/html/cgi-bin/firewall.cgi
> +++ b/html/cgi-bin/firewall.cgi
> @@ -757,6 +757,7 @@ sub checkrule
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if($fwdf=
wsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} eq
> ''){$fwdfwsettings{'dnatport'}=3D$custsrvport;}
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if($fwdfwse=
ttings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'grp3'} eq
> 'cust_srv'){$fwdfwsettings{'dnatport'}=3D$custsrvport;}
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0}
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0#check if DNAT port is multiple
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0if($fwdfwsettings{'nat'} eq 'dnat' &&
> $fwdfwsettings{'dnatport'} ne ''){


--===============2010478481833653294==--