public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] media.cgi: Fix parsing output of iostat
Date: Sat, 25 Sep 2021 13:34:30 +0200	[thread overview]
Message-ID: <1b6278ae-43bd-70dd-c71d-da7f1f67fb2b@ipfire.org> (raw)
In-Reply-To: <20210924091450.23865-1-michael.tremer@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

Acked-by: Adolf Belka <adolf.belka(a)ipfire.org>

Sorry that I missed the change of output of iostat when I tested my 
sysstat update patch.

Thanks for finding and fixing.

On 24/09/2021 11:14, Michael Tremer wrote:
> Since the last update of sysstat, the output of iostat has changed and
> the web user interface showed wrong values.
>
> This is now being fixed in this patch.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   html/cgi-bin/media.cgi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
> index cc8f84d0a..af75d1bf3 100644
> --- a/html/cgi-bin/media.cgi
> +++ b/html/cgi-bin/media.cgi
> @@ -135,8 +135,8 @@ END
>   }
>   close DF;
>   my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
> -my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
> -my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
> +my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
> +my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$7}');
>   print "<tr><td colspan='3'>&nbsp;\n<tr><td colspan='3'><h3>transfers</h3></td></tr>";
>   my $i=0;
>   

-- 
Sent from my laptop


  reply	other threads:[~2021-09-25 11:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  9:14 Michael Tremer
2021-09-25 11:34 ` Adolf Belka [this message]
2021-09-27 18:43   ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b6278ae-43bd-70dd-c71d-da7f1f67fb2b@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox