From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] media.cgi: Fix parsing output of iostat
Date: Sat, 25 Sep 2021 13:34:30 +0200
Message-ID: <1b6278ae-43bd-70dd-c71d-da7f1f67fb2b@ipfire.org>
In-Reply-To: <20210924091450.23865-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2457385461318755014=="
List-Id: <development.lists.ipfire.org>

--===============2457385461318755014==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Acked-by: Adolf Belka <adolf.belka(a)ipfire.org>

Sorry that I missed the change of output of iostat when I tested my=20
sysstat update patch.

Thanks for finding and fixing.

On 24/09/2021 11:14, Michael Tremer wrote:
> Since the last update of sysstat, the output of iostat has changed and
> the web user interface showed wrong values.
>
> This is now being fixed in this patch.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   html/cgi-bin/media.cgi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
> index cc8f84d0a..af75d1bf3 100644
> --- a/html/cgi-bin/media.cgi
> +++ b/html/cgi-bin/media.cgi
> @@ -135,8 +135,8 @@ END
>   }
>   close DF;
>   my @iostat1 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print=
 \$1}');
> -my @iostat2 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print =
\$5}');
> -my @iostat3 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print =
\$6}');
> +my @iostat2 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print =
\$6}');
> +my @iostat3 =3D qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print =
\$7}');
>   print "<tr><td colspan=3D'3'>&nbsp;\n<tr><td colspan=3D'3'><h3>transfers<=
/h3></td></tr>";
>   my $i=3D0;
>  =20

--=20
Sent from my laptop


--===============2457385461318755014==--