* [PATCH] media.cgi: Fix parsing output of iostat
@ 2021-09-24 9:14 Michael Tremer
2021-09-25 11:34 ` Adolf Belka
0 siblings, 1 reply; 3+ messages in thread
From: Michael Tremer @ 2021-09-24 9:14 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
Since the last update of sysstat, the output of iostat has changed and
the web user interface showed wrong values.
This is now being fixed in this patch.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
html/cgi-bin/media.cgi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
index cc8f84d0a..af75d1bf3 100644
--- a/html/cgi-bin/media.cgi
+++ b/html/cgi-bin/media.cgi
@@ -135,8 +135,8 @@ END
}
close DF;
my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
-my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
-my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
+my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
+my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$7}');
print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>transfers</h3></td></tr>";
my $i=0;
--
2.31.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media.cgi: Fix parsing output of iostat
2021-09-24 9:14 [PATCH] media.cgi: Fix parsing output of iostat Michael Tremer
@ 2021-09-25 11:34 ` Adolf Belka
2021-09-27 18:43 ` Michael Tremer
0 siblings, 1 reply; 3+ messages in thread
From: Adolf Belka @ 2021-09-25 11:34 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
Acked-by: Adolf Belka <adolf.belka(a)ipfire.org>
Sorry that I missed the change of output of iostat when I tested my
sysstat update patch.
Thanks for finding and fixing.
On 24/09/2021 11:14, Michael Tremer wrote:
> Since the last update of sysstat, the output of iostat has changed and
> the web user interface showed wrong values.
>
> This is now being fixed in this patch.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> html/cgi-bin/media.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
> index cc8f84d0a..af75d1bf3 100644
> --- a/html/cgi-bin/media.cgi
> +++ b/html/cgi-bin/media.cgi
> @@ -135,8 +135,8 @@ END
> }
> close DF;
> my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
> -my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
> -my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
> +my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
> +my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$7}');
> print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>transfers</h3></td></tr>";
> my $i=0;
>
--
Sent from my laptop
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media.cgi: Fix parsing output of iostat
2021-09-25 11:34 ` Adolf Belka
@ 2021-09-27 18:43 ` Michael Tremer
0 siblings, 0 replies; 3+ messages in thread
From: Michael Tremer @ 2021-09-27 18:43 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]
Hello,
No problem :)
> On 25 Sep 2021, at 12:34, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>
> Acked-by: Adolf Belka <adolf.belka(a)ipfire.org>
>
> Sorry that I missed the change of output of iostat when I tested my sysstat update patch.
>
> Thanks for finding and fixing.
>
> On 24/09/2021 11:14, Michael Tremer wrote:
>> Since the last update of sysstat, the output of iostat has changed and
>> the web user interface showed wrong values.
>>
>> This is now being fixed in this patch.
>>
>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
>> ---
>> html/cgi-bin/media.cgi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/html/cgi-bin/media.cgi b/html/cgi-bin/media.cgi
>> index cc8f84d0a..af75d1bf3 100644
>> --- a/html/cgi-bin/media.cgi
>> +++ b/html/cgi-bin/media.cgi
>> @@ -135,8 +135,8 @@ END
>> }
>> close DF;
>> my @iostat1 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$1}');
>> -my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$5}');
>> -my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
>> +my @iostat2 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$6}');
>> +my @iostat3 = qx(/usr/bin/iostat -dm -p | grep -v "Linux" | awk '{print \$7}');
>> print "<tr><td colspan='3'> \n<tr><td colspan='3'><h3>transfers</h3></td></tr>";
>> my $i=0;
>>
>
> --
> Sent from my laptop
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-27 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 9:14 [PATCH] media.cgi: Fix parsing output of iostat Michael Tremer
2021-09-25 11:34 ` Adolf Belka
2021-09-27 18:43 ` Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox