From: David Allen <codermotor@gmail.com>
To: development@lists.ipfire.org
Subject: Re: diagrams - all over the CGIs
Date: Sun, 24 May 2020 13:50:58 -0700 [thread overview]
Message-ID: <1b69843a-4d60-d646-5cd5-dc5f975fbaa7@gmail.com> (raw)
In-Reply-To: <83755B15-1C34-4BE9-8F6E-6FEC2B1220C0@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
Yay!
As a lowly user, I mentioned this a few years ago but I figured my
comment just went into the bit bucket. I'm glad I'm not the only one to
see those "Duh!"s all over the place :-D
On 5/13/20 2:59 AM, Michael Tremer wrote:
> Hi,
>
>> On 13 May 2020, at 09:38, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>
>> Hi,
>>
>> this just came to my view while looking at Peters patches for
>> 'system.cgi' and 'graphs.pl' ("properly translate load average graph").
>>
>> Searching for the translation string ...$Lang::tr{'graph'}... I found
>> it twenty-two(!) times - only in '/srv/web/ipfire/cgi-bin/*'.
>>
>> What are these repetitions good for?
>>
>> I mean, you click on "Network (external)". You read the topic
>> "Net-Traffic graphs (external)" or "... (internal).
>>
>> You know: here I'll find ... graphs. Ok. Lets see.
>>
>> But why is there "red0 *Graph*", green0 *Graph*", "blue0 *Graph*", or
>> CPU *Graph* / CPU frequency *Graph*, Memory *Graph*, Swap *Graph*, sda
>> *Graph*, ACPI Thermal-Zone Temp *Graph* - over and over again?
>
> Yeah, we absolutely do not need that word in the headline.
>
> “Memory” should make it clear what we are showing. It is obvious that the graph is a graph.
>
>> My two cents: I think we don't need this translation string at these
>> specific points in the WUI.
>
> Would you like to send in a patch for this?
>
> Best,
> -Michael
>
>>
>> Opinions?
>>
>> Best,
>> Matthias
>
next prev parent reply other threads:[~2020-05-24 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 8:38 Matthias Fischer
2020-05-13 9:59 ` Michael Tremer
2020-05-13 14:14 ` Matthias Fischer
2020-05-24 20:50 ` David Allen [this message]
2020-05-25 9:27 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b69843a-4d60-d646-5cd5-dc5f975fbaa7@gmail.com \
--to=codermotor@gmail.com \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox