From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] rules.pl: fix missing blank in 'if'-condition
Date: Mon, 21 Aug 2017 18:16:43 +0200
Message-ID: <1bdbdece-3cbb-9a7b-628e-506cc18da2bc@ipfire.org>
In-Reply-To: <1503314272.2673.11.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6099227240959032929=="
List-Id: <development.lists.ipfire.org>

--===============6099227240959032929==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Hi,

For unknown reasons I couldn't reproduce this error even with the
original file. So I deferred this patch - I'm not sure anymore that this
is really a bug!?

The whole story (german) can be found here:
https://forum.ipfire.org/viewtopic.php?f=22&t=19304

I fear I was a bit too fast...

Best,
Matthias

On 21.08.2017 13:17, Michael Tremer wrote:
> Hi,
> 
> this has been set to deferred on Patchwork. Why?
> 
> Best,
> -Michael
> 
> On Sat, 2017-08-19 at 13:30 +0200, Matthias Fischer wrote:
>> Triggered by https://forum.ipfire.org/viewtopic.php?f=22&t=19304
>> 
>> Best,
>> Matthias
>> 
>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>> ---
>>  config/firewall/rules.pl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/config/firewall/rules.pl b/config/firewall/rules.pl
>> index 8b0c6ddc8..efbe9cfef 100644
>> --- a/config/firewall/rules.pl
>> +++ b/config/firewall/rules.pl
>> @@ -608,7 +608,7 @@ sub geoipblock {
>>  	# create iptables rules, if blocking this country
>>  	# is enabled.
>>  	foreach my $location (@locations) {
>> -		if($geoipsettings{$location} eq "on") {
>> +		if ($geoipsettings{$location} eq "on") {
>>  			run("$IPTABLES -A GEOIPBLOCK -m geoip --src-cc $location -j DROP");
>>  		}
>>  	}
> 


--===============6099227240959032929==--