public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
* Re: [PATCH] libtirpc: change from package to common v2
       [not found] <1468489393.2513.0@mail01.ipfire.org>
@ 2016-07-14  9:49 ` Michael Tremer
  2016-07-15 16:51   ` Marcel Lorenz
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Tremer @ 2016-07-14  9:49 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 2395 bytes --]

Why does this package have to be in the core system?

On Thu, 2016-07-14 at 11:43 +0200, Jonatan Schlag wrote:
> Am Mo, 11. Jul, 2016 um 8:37 schrieb Marcel Lorenz <marcel.lorenz(a)ipfire.org>:
> > The dependency from rpcbind package are removed
> > 
> > Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
> > ---
> >  config/rootfiles/{packages => common}/libtirpc | 0
> >  lfs/libtirpc                                   | 6 ------
> >  lfs/rpcbind                                    | 2 +-
> >  3 files changed, 1 insertion(+), 7 deletions(-)
> >  rename config/rootfiles/{packages => common}/libtirpc (100%)
> > 
> > diff --git a/config/rootfiles/packages/libtirpc
> > b/config/rootfiles/common/libtirpc
> > similarity index 100%
> > rename from config/rootfiles/packages/libtirpc
> > rename to config/rootfiles/common/libtirpc
> > diff --git a/lfs/libtirpc b/lfs/libtirpc
> > index 382d7e5..c37fa9b 100644
> > --- a/lfs/libtirpc
> > +++ b/lfs/libtirpc
> > @@ -31,10 +31,7 @@ DL_FILE    = $(THISAPP).tar.bz2
> >  DL_FROM    = $(URL_IPFIRE)
> >  DIR_APP    = $(DIR_SRC)/$(THISAPP)
> >  TARGET     = $(DIR_INFO)/$(THISAPP)
> > -PROG       = libtirpc
> > -PAK_VER    = 1
> >  
> > -DEPS       = ""
> >  
> >  ###########################################################################
> > ####
> >  # Top-level Rules
> > @@ -54,9 +51,6 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
> >  
> >  md5 : $(subst %,%_MD5,$(objects))
> >  
> > -dist:
> > -	@$(PAK)
> > -
> >  ###########################################################################
> > ####
> >  # Downloading, checking, md5sum
> >  ###########################################################################
> > ####
> > diff --git a/lfs/rpcbind b/lfs/rpcbind
> > index d9e2885..99fccbc 100644
> > --- a/lfs/rpcbind
> > +++ b/lfs/rpcbind
> > @@ -34,7 +34,7 @@ TARGET     = $(DIR_INFO)/$(THISAPP)
> >  PROG       = rpcbind
> >  PAK_VER    = 1
> >  
> > -DEPS       = "libtirpc"
> > +DEPS       = ""
> >  
> >  ###########################################################################
> > ####
> >  # Top-level Rules
> > -- 
> > 1.9.1
> Reviewed-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libtirpc: change from package to common v2
  2016-07-14  9:49 ` [PATCH] libtirpc: change from package to common v2 Michael Tremer
@ 2016-07-15 16:51   ` Marcel Lorenz
  0 siblings, 0 replies; 3+ messages in thread
From: Marcel Lorenz @ 2016-07-15 16:51 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 2771 bytes --]

Am 2016-07-14 11:49, schrieb Michael Tremer:
> Why does this package have to be in the core system?
> 
Hi Michael,
Hi Jonatan,

libtirpc is a hard dependency for new lsof package
and losf is in core system. Without lsof wont build.

The CFGL="-L./lib -ltirpc" in losof package
instruct the libtirpc libraries location to make command

Best,
Marcel

> On Thu, 2016-07-14 at 11:43 +0200, Jonatan Schlag wrote:
>> Am Mo, 11. Jul, 2016 um 8:37 schrieb Marcel Lorenz 
>> <marcel.lorenz(a)ipfire.org>:
>> > The dependency from rpcbind package are removed
>> >
>> > Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
>> > ---
>> >  config/rootfiles/{packages => common}/libtirpc | 0
>> >  lfs/libtirpc                                   | 6 ------
>> >  lfs/rpcbind                                    | 2 +-
>> >  3 files changed, 1 insertion(+), 7 deletions(-)
>> >  rename config/rootfiles/{packages => common}/libtirpc (100%)
>> >
>> > diff --git a/config/rootfiles/packages/libtirpc
>> > b/config/rootfiles/common/libtirpc
>> > similarity index 100%
>> > rename from config/rootfiles/packages/libtirpc
>> > rename to config/rootfiles/common/libtirpc
>> > diff --git a/lfs/libtirpc b/lfs/libtirpc
>> > index 382d7e5..c37fa9b 100644
>> > --- a/lfs/libtirpc
>> > +++ b/lfs/libtirpc
>> > @@ -31,10 +31,7 @@ DL_FILE    = $(THISAPP).tar.bz2
>> >  DL_FROM    = $(URL_IPFIRE)
>> >  DIR_APP    = $(DIR_SRC)/$(THISAPP)
>> >  TARGET     = $(DIR_INFO)/$(THISAPP)
>> > -PROG       = libtirpc
>> > -PAK_VER    = 1
>> >  
>> > -DEPS       = ""
>> >  
>> >  ###########################################################################
>> > ####
>> >  # Top-level Rules
>> > @@ -54,9 +51,6 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
>> >  
>> >  md5 : $(subst %,%_MD5,$(objects))
>> >  
>> > -dist:
>> > -	@$(PAK)
>> > -
>> >  ###########################################################################
>> > ####
>> >  # Downloading, checking, md5sum
>> >  ###########################################################################
>> > ####
>> > diff --git a/lfs/rpcbind b/lfs/rpcbind
>> > index d9e2885..99fccbc 100644
>> > --- a/lfs/rpcbind
>> > +++ b/lfs/rpcbind
>> > @@ -34,7 +34,7 @@ TARGET     = $(DIR_INFO)/$(THISAPP)
>> >  PROG       = rpcbind
>> >  PAK_VER    = 1
>> >  
>> > -DEPS       = "libtirpc"
>> > +DEPS       = ""
>> >  
>> >  ###########################################################################
>> > ####
>> >  # Top-level Rules
>> > -- 
>> > 1.9.1
>> Reviewed-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] libtirpc: change from package to common v2
@ 2016-07-11  6:37 Marcel Lorenz
  0 siblings, 0 replies; 3+ messages in thread
From: Marcel Lorenz @ 2016-07-11  6:37 UTC (permalink / raw)
  To: development

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

The dependency from rpcbind package are removed

Signed-off-by: Marcel Lorenz <marcel.lorenz(a)ipfire.org>
---
 config/rootfiles/{packages => common}/libtirpc | 0
 lfs/libtirpc                                   | 6 ------
 lfs/rpcbind                                    | 2 +-
 3 files changed, 1 insertion(+), 7 deletions(-)
 rename config/rootfiles/{packages => common}/libtirpc (100%)

diff --git a/config/rootfiles/packages/libtirpc b/config/rootfiles/common/libtirpc
similarity index 100%
rename from config/rootfiles/packages/libtirpc
rename to config/rootfiles/common/libtirpc
diff --git a/lfs/libtirpc b/lfs/libtirpc
index 382d7e5..c37fa9b 100644
--- a/lfs/libtirpc
+++ b/lfs/libtirpc
@@ -31,10 +31,7 @@ DL_FILE    = $(THISAPP).tar.bz2
 DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
-PROG       = libtirpc
-PAK_VER    = 1
 
-DEPS       = ""
 
 ###############################################################################
 # Top-level Rules
@@ -54,9 +51,6 @@ download :$(patsubst %,$(DIR_DL)/%,$(objects))
 
 md5 : $(subst %,%_MD5,$(objects))
 
-dist:
-	@$(PAK)
-
 ###############################################################################
 # Downloading, checking, md5sum
 ###############################################################################
diff --git a/lfs/rpcbind b/lfs/rpcbind
index d9e2885..99fccbc 100644
--- a/lfs/rpcbind
+++ b/lfs/rpcbind
@@ -34,7 +34,7 @@ TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = rpcbind
 PAK_VER    = 1
 
-DEPS       = "libtirpc"
+DEPS       = ""
 
 ###############################################################################
 # Top-level Rules
-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-07-15 16:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1468489393.2513.0@mail01.ipfire.org>
2016-07-14  9:49 ` [PATCH] libtirpc: change from package to common v2 Michael Tremer
2016-07-15 16:51   ` Marcel Lorenz
2016-07-11  6:37 Marcel Lorenz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox