From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] embed background image in redirect template Date: Thu, 28 Jun 2018 13:00:12 +0100 Message-ID: <1f699226602f2451fdd1651b19a1f70417cf4342.camel@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5139369841665419601==" List-Id: --===============5139369841665419601== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Yes, you can have a placeholder in the CGI file and replace it at build time with the image file. - -Michael On Wed, 2018-06-27 at 23:10 +0200, Peter M=C3=BCller wrote: > Hello Michael, >=20 > is it okay for you if we insert the base64 encoded image into the HTML > page during running a Pakfire build? That way, we won't need a CGI nor exec= ute > this sever-side multiple times. >=20 > I thought of a sed-command in an lfs file... >=20 > Best regards, > Peter M=C3=BCller >=20 > > Hello, > >=20 > > although I generally agree with the fix, this is not the best solution. W= hen > > ever the image file is changed, this needs to be manually changed, too. > > That's > > not nice. > >=20 > > It would be better to read the image file when rendering the HTML output = and > > encoding it into base64 on the fly. > >=20 > > Best, > > -Michael > >=20 > > On Sat, 2018-06-16 at 20:48 +0200, Peter M=C3=BCller wrote: > > > Embed the IPFire background image into the redirect template > > > directly via CSS instead of loading it from somewhere else. > > > This is necessary because of Content Security Policy (CSP) and > > > fixes #11650. > > > Signed-off-by: Peter M=C3=BCller > > > --- > > > html/html/redirect-templates/legacy/template.html | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > diff --git a/html/html/redirect-templates/legacy/template.html > > > b/html/html/redirect-templates/legacy/template.html > > > index b5fb61ebe..8a6a563a3 100644 > > > --- a/html/html/redirect-templates/legacy/template.html > > > +++ b/html/html/redirect-templates/legacy/template.html > > > @@ -3,11 +3,17 @@ > > > > > > > > charset=3Dutf-8">=20 > > > ACCESS MESSAGE > > > + > > > > > > > > > > > > > > > - > > > > > >
> > align=3D"center" background=3D" > > NAME=3D"ADDRESS">/images/background.gif"> > > > + > > height=3D'152px' > > > align=3D"center" class=3D"image"> 
> > > > > width=3D'80%'> >=20 >=20 -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE5/rW5l3GGe2ypktxgHnw/2+QCQcFAls0zc0ACgkQgHnw/2+Q CQeBUg//e3Jad8ovpKBkhlvPLTp6uTQDbSD2Y7u00cjQ/Lycgej63g2hsITQgzhE FbhblFSGI+GAgjZLnUqVOsmAphkVu3dMT1hzaGEIJitoNsSC8UUJMy3grB0vpaPf Jur2K3bzWJTGJeQr5cWfPX7uBNCdk7SJa32BVdlwpzyaNGVjDJ2y0FbUSMZ6atoD jAChCGyq6QNCTTAvqZTE6I8rrKsDI+CyQPFQKk7mrrwFhlgLBbaeliIINcT6FMuy ap0sC6SfGReWrXgPdZpyl8lORRofm2lzsnSosI70Q3KnBECkiCvd0rf3y9ifnEiR PL4dTwliJLA6GH8ibXXGowp9xyp1Gkxsg+g4Zi04neam/ZMm7CIFUpU5lxHNc656 UynCS+xidnZAJmvIBPnT666wjHzzXcSaTuskVKPJFuxqhgqOXaxzSZEO7vKmLwFR 8K98IC0fPGwAS5WSxN6NjchUzRlJHlc7/gOry73E5n5xbtEmnqi9PhD7fWwG24r/ hu3kUwqsoKlFjSlJ98Ncbw+NQWnsHrVtNQPtDAp6C71aRJzP01+NwDxaWo/f/kx0 HJbD6XIMuPb71FP08/D4IvSXAHdhkgKFmGnIOPC7ppSOZ8eGV1wl7ivALETvOt2/ Y7aL6v2novKxMMtMZrXiWWEeGTQnsNvHNq75OnKMMWt4KjMF52k=3D =3DBOwA -----END PGP SIGNATURE----- --===============5139369841665419601==--