public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenSSH: do not ship ssh-keysign anymore
Date: Mon, 17 May 2021 12:58:35 +0200	[thread overview]
Message-ID: <1f9af340-c59b-58f3-8308-5ccb5301634f@ipfire.org> (raw)
In-Reply-To: <cdbc59f1-e0d3-3bf6-400e-04fc8fd8ca48@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 16/05/2021 22:48, Peter Müller wrote:
> To my surprise, this binary comes with suid flag set, and since we do
> not have SSH key signing enabled, there is no need to ship it with
> IPFire.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
>   config/rootfiles/common/openssh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/rootfiles/common/openssh b/config/rootfiles/common/openssh
> index f2f8ea6c5..c3666d914 100644
> --- a/config/rootfiles/common/openssh
> +++ b/config/rootfiles/common/openssh
> @@ -19,7 +19,7 @@ usr/bin/ssh-keygen
>   usr/bin/ssh-keyscan
>   #usr/lib/openssh
>   usr/lib/openssh/sftp-server
> -usr/lib/openssh/ssh-keysign
> +#usr/lib/openssh/ssh-keysign
>   usr/lib/openssh/ssh-pkcs11-helper
>   usr/lib/openssh/ssh-sk-helper
>   usr/sbin/sshd

      reply	other threads:[~2021-05-17 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 20:48 Peter Müller
2021-05-17 10:58 ` Adolf Belka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f9af340-c59b-58f3-8308-5ccb5301634f@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox