Re: [PATCH] libtirpc: change from package to common

[Jonatan Schlag <jonatan.schlag@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]

Hi Marcel

Marcel Lorenz – Do, 7. Juli 2016 21:02
> Hi Jonatan,
> 
> thx for support me... :)
> 
When I can help I am happy to do so :-)

> i make my patches, if it working on IPFire, identical to Linux from 
> Scratch.
> For this lib: 
> www.linuxfromscratch.org/blfs/view/svn/basicnet/libtirpc.html

This is definitely not the worst source, but there are some differences which make some things not useful on IPFire.

> 
> if their other notions have, please tell me share this with.
> So I can create the patch as desired. For me it is important that it 
> just works ...
> 
It should work definitely :-)  but the advice 

"mv -v /usr/lib/libtirpc.so.* ...: Move shared libraries into /lib so they are available before /usr is mounted."
is not useful for IPFire on IPFire because /usr is not on a separated partition. There are Distribution where /usr is located on a seperated partition. On this Distribution it is useful to move the libs to /lib because they are earlier available as when they are located on the separated partition /usr.

So on IPfire you can ignore this advice.

> (google translator)
> 
> if you wish, i make it new without --prefix=/usr and mv -v 
> /usr/lib/libtirpc.so
> 

Why want you to remove --prefix=/usr ?
We should use --prefix=/usr everywhere else things goes into /usr/local which is bad.

Just remove 
mv -v /usr/lib/libtirpc.so.* /lib
ln -sfv /lib/libtirpc.so.3.0.0 /usr/lib/libtirpc.so

and the patch should fine with some other adjustment

-	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar jxf $(DIR_DL)/$(DL_FILE)
Why did you change tar jxf to tar axf ? If there is no reason do do this, do not change this.
-	cd $(DIR_APP) && ./configure --prefix=/usr --sysconfdir=/etc --disable-gssapi --disable-ipv6
-	cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
Same as 2 lines up  If there is no reason do do this, do not change this.
+	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
+	cd $(DIR_APP) && ./configure --prefix=/usr \
+			--sysconfdir=/etc \
+			--disable-static \
+			--disable-gssapi \
+			--disable-ipv6
+	cd $(DIR_APP) && make $(MAKETUNING)

And please remove libtirpc as a dependency from rpcbind and bump the package version. Elsewise we run into dependency issues

Regards Jonatan