From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonatan Schlag <jonatan.schlag@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] libtirpc: change from package to common
Date: Thu, 07 Jul 2016 19:27:51 +0000
Message-ID: <20160707192751.Horde.UOqGXzAdtinEcY9sJ-J92PT@owncloud.helmsklamm.local.familyschlag>
In-Reply-To: <a5ffac89e2b1a117477af604affd0791@mail01.ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2159375398060506190=="
List-Id: <development.lists.ipfire.org>

--===============2159375398060506190==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Marcel

Marcel Lorenz =E2=80=93 Do, 7. Juli 2016 21:02
> Hi Jonatan,
>=20
> thx for support me... :)
>=20
When I can help I am happy to do so :-)

> i make my patches, if it working on IPFire, identical to Linux from=20
> Scratch.
> For this lib:=20
> www.linuxfromscratch.org/blfs/view/svn/basicnet/libtirpc.html

This is definitely not the worst source, but there are some differences which=
 make some things not useful on IPFire.

>=20
> if their other notions have, please tell me share this with.
> So I can create the patch as desired. For me it is important that it=20
> just works ...
>=20
It should work definitely :-)  but the advice=20

"mv -v /usr/lib/libtirpc.so.* ...: Move shared libraries into /lib so they ar=
e available before /usr is mounted."
is not useful for IPFire on IPFire because /usr is not on a separated partiti=
on. There are Distribution where /usr is located on a seperated partition. On=
 this Distribution it is useful to move the libs to /lib because they are ear=
lier available as when they are located on the separated partition /usr.

So on IPfire you can ignore this advice.

> (google translator)
>=20
> if you wish, i make it new without --prefix=3D/usr and mv -v=20
> /usr/lib/libtirpc.so
>=20

Why want you to remove --prefix=3D/usr ?
We should use --prefix=3D/usr everywhere else things goes into /usr/local whi=
ch is bad.

Just remove=20
mv -v /usr/lib/libtirpc.so.* /lib
ln -sfv /lib/libtirpc.so.3.0.0 /usr/lib/libtirpc.so

and the patch should fine with some other adjustment

-	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar jxf $(DIR_DL)/$(DL_FILE)
Why did you change tar jxf to tar axf ? If there is no reason do do this, do =
not change this.
-	cd $(DIR_APP) && ./configure --prefix=3D/usr --sysconfdir=3D/etc --disable-=
gssapi --disable-ipv6
-	cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
Same as 2 lines up  If there is no reason do do this, do not change this.
+	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
+	cd $(DIR_APP) && ./configure --prefix=3D/usr \
+			--sysconfdir=3D/etc \
+			--disable-static \
+			--disable-gssapi \
+			--disable-ipv6
+	cd $(DIR_APP) && make $(MAKETUNING)

And please remove libtirpc as a dependency from rpcbind and bump the package =
version. Elsewise we run into dependency issues

Regards Jonatan



--===============2159375398060506190==--