From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fischer To: development@lists.ipfire.org Subject: [PATCH] BUG11494 Date: Sun, 01 Oct 2017 20:43:16 +0200 Message-ID: <20171001184316.1862-1-matthias.fischer@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2510323900792354869==" List-Id: --===============2510323900792354869== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Apache 2.4.27 breaks 'ExtraHD'-GUI =3D> "Internal server error": Opening 'extrahd.cgi' led to: "Response header name 'scanhd idescanhd partitionsCache-control' contains invalid characters, aborting request". Triggered by: https://forum.ipfire.org/viewtopic.php?f=3D27&t=3D19550#p111030 Discussion: https://forum.ipfire.org/viewtopic.php?f=3D50&t=3D19563&sid=3D575337ac1caf1df= 492fced01ca6243de#p111048 Solution (thanks gocart!): https://forum.ipfire.org/viewtopic.php?f=3D22&t=3D19563#p111052 =3D> Redirect '/usr/local/bin/extrahdctrl'-output to stdout. Furthermore, I added a "workaround to suppress a warning when a variable is u= sed only once" in 'extrahd.cgi', because after activating 'use warnings' and 'fatals to brow= ser' I got "possible typo"-warnings in 'error_log'. Plus, fixed typo in 'extrahd.pl'. Best, Matthias Signed-off-by: Matthias Fischer --- config/extrahd/extrahd.pl | 2 +- html/cgi-bin/extrahd.cgi | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/config/extrahd/extrahd.pl b/config/extrahd/extrahd.pl index 6593ca47d..3c6fa0280 100644 --- a/config/extrahd/extrahd.pl +++ b/config/extrahd/extrahd.pl @@ -77,7 +77,7 @@ if ( "$ARGV[0]" eq "mount" ) { if ( ! `/bin/mount | /bin/fgrep $ARGV[1]` ) { system("/bin/cp -f /etc/fstab $fstab"); system("/bin/fgrep -v $ARGV[1] <$fstab >/etc/fstab"); - print "Succesfully umounted $ARGV[1].\n"; + print "Successfully umounted $ARGV[1].\n"; exit(0); } else { print "Can't umount $ARGV[1].\n"; diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi index 5a6fbce83..da1efb2dd 100644 --- a/html/cgi-bin/extrahd.cgi +++ b/html/cgi-bin/extrahd.cgi @@ -48,8 +48,13 @@ my $partitionentry =3D ""; my $devicefile =3D "/var/ipfire/extrahd/devices"; my $scanfile =3D "/var/ipfire/extrahd/scan"; my $partitionsfile =3D "/var/ipfire/extrahd/partitions"; -system("/usr/local/bin/extrahdctrl scanhd ide"); -system("/usr/local/bin/extrahdctrl scanhd partitions"); + +#workaround to suppress a warning when a variable is used only once +my @dummy =3D ( ${Header::colourgreen}, ${Header::colourred} ); +undef (@dummy); + +system("/usr/local/bin/extrahdctrl scanhd ide >/dev/null"); +system("/usr/local/bin/extrahdctrl scanhd partitions >/dev/null"); =20 &Header::showhttpheaders(); =20 --=20 2.14.2 --===============2510323900792354869==--