From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] Suggestion: Related to BUG11494 - removed PRINT-line in 'extrahd.pl'
Date: Tue, 03 Oct 2017 15:40:25 +0200 [thread overview]
Message-ID: <20171003134025.24294-1-matthias.fischer@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
Just a suggestion - I don't want it to be forgotten - so I deleted
the useless(!?) line 51 in '/config/extrahd.pl'.
As shown in https://forum.ipfire.org/viewtopic.php?f=50&t=19563#p111055
PRINT-output somehow garbles bash-prompt.
Starting 'extrahd.pl' from console:
...
root(a)ipfire: /var/ipfire/extrahd/bin # ./extrahd.pl scanhd ide
...
Leads to:
...
scanhd ideroot(a)ipfire: /var/ipfire/extrahd/bin #
^^^^^^^^^^
...
I think its just a forgotten debug line.
Jm2C - Best,
Matthias
Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
---
| 2 --
1 file changed, 2 deletions(-)
--git a/config/extrahd/extrahd.pl b/config/extrahd/extrahd.pl
index 3c6fa0280..3b57e9230 100644
--- a/config/extrahd/extrahd.pl
+++ b/config/extrahd/extrahd.pl
@@ -48,8 +48,6 @@ close FILE;
############################################################################################################################
############################################################################################################################
-print "$ARGV[0] $ARGV[1]";
-
if ( "$ARGV[0]" eq "mount" ) {
system("/bin/cp -f /etc/fstab $fstab");
--
2.14.2
next reply other threads:[~2017-10-03 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 13:40 Matthias Fischer [this message]
2017-10-04 15:47 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003134025.24294-1-matthias.fischer@ipfire.org \
--to=matthias.fischer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox