public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@link38.eu>
To: development@lists.ipfire.org
Subject: [PATCH] use CHAP for dial-in as default
Date: Sun, 19 Nov 2017 14:47:30 +0100	[thread overview]
Message-ID: <20171119144730.1dca97e2.peter.mueller@link38.eu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

Use CHAP as default setting for PPPoE dial-in connections.

Although CHAP does not provide strong transport security
at all, it is better than submitting credentials in plain text.

Enforcing CHAP prevents the system from silently falling
down to no encryption (MITM attack!).

Existing installations remain untouched.

Signed-off-by: Peter Müller <peter.mueller(a)link38.eu>
---
 html/cgi-bin/pppsetup.cgi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
index 4b45ee50c..a96dce9df 100644
--- a/html/cgi-bin/pppsetup.cgi
+++ b/html/cgi-bin/pppsetup.cgi
@@ -1042,7 +1042,7 @@ sub initprofile
         $pppsettings{'HOLDOFF'} = 30;
         $pppsettings{'TIMEOUT'} = 15;
         $pppsettings{'MODULATION'} = 'AUTO';
-        $pppsettings{'AUTH'} = 'pap-or-chap';
+        $pppsettings{'AUTH'} = 'chap';
         $pppsettings{'DNS'} = 'Automatic';
         $pppsettings{'DEBUG'} = 'off';
         $pppsettings{'BACKUPPROFILE'} = $pppsettings{'PROFILE'};
-- 
2.13.6


             reply	other threads:[~2017-11-19 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-19 13:47 Peter Müller [this message]
2017-11-19 15:34 ` Michael Tremer
2017-11-20 18:30   ` Peter Müller
2017-11-21 12:25     ` Michael Tremer
2017-12-04 16:40       ` Peter Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171119144730.1dca97e2.peter.mueller@link38.eu \
    --to=peter.mueller@link38.eu \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox