From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@link38.eu>
To: development@lists.ipfire.org
Subject: Re: [PATCH] show IDS rule names correctly in WebUI log
Date: Mon, 20 Nov 2017 19:13:14 +0100
Message-ID: <20171120191314.4b55e2b5.peter.mueller@link38.eu>
In-Reply-To: <1511192984.4838.541.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3687189672191269830=="
List-Id: <development.lists.ipfire.org>

--===============3687189672191269830==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello Michael,

Emerging Threats changed some snort signature IDs to 5 digits
a while, which were not displayed in the WebUI since "([0-9]{1,4})"
did not match on it.

This patch adjusts the regular expression so they are displayed
correctly now.

Should I send in a second version with this description? Thought
the bug ID would be enough...

Best regards, 
Peter Müller

> Hello,
> 
> can you explain what this patch is supposed to change?
> 
> -Michael
> 
> On Sun, 2017-11-19 at 18:04 +0100, Peter Müller wrote:
> > Fixes #11519.
> > 
> > Signed-off-by: Peter Müller <peter.mueller(a)link38.eu>
> > ---
> >  html/cgi-bin/logs.cgi/ids.dat | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.dat
> > index 44b3abdac..98176d690 100644
> > --- a/html/cgi-bin/logs.cgi/ids.dat
> > +++ b/html/cgi-bin/logs.cgi/ids.dat
> > @@ -387,7 +387,7 @@ sub processevent
> >  				}
> >  				($title,$classification,$priority,$date,$time
> > ,$srcip,$srcport,$destip,$destport, $sid) =
> > ("n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a", "n/a");
> >  				@refs = ();
> > -				$_ =~ m/:([0-9]{1,4})\] (.*) \[\*\*\]/;
> > +				$_ =~ m/:([0-9]{1,5})\] (.*) \[\*\*\]/;
> >  				$title = &Header::cleanhtml($2,"y");
> >  			}
> >  			if ($_ =~ m/Classification: (.*)\] \[Priority:
> > (\d)\]/) {  


--===============3687189672191269830==--