* [PATCH] show IDS rule names correctly in WebUI log @ 2017-11-19 17:04 Peter Müller 2017-11-20 15:49 ` Michael Tremer 0 siblings, 1 reply; 4+ messages in thread From: Peter Müller @ 2017-11-19 17:04 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 795 bytes --] Fixes #11519. Signed-off-by: Peter Müller <peter.mueller(a)link38.eu> --- html/cgi-bin/logs.cgi/ids.dat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.dat index 44b3abdac..98176d690 100644 --- a/html/cgi-bin/logs.cgi/ids.dat +++ b/html/cgi-bin/logs.cgi/ids.dat @@ -387,7 +387,7 @@ sub processevent } ($title,$classification,$priority,$date,$time,$srcip,$srcport,$destip,$destport, $sid) = ("n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a", "n/a"); @refs = (); - $_ =~ m/:([0-9]{1,4})\] (.*) \[\*\*\]/; + $_ =~ m/:([0-9]{1,5})\] (.*) \[\*\*\]/; $title = &Header::cleanhtml($2,"y"); } if ($_ =~ m/Classification: (.*)\] \[Priority: (\d)\]/) { -- 2.13.6 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] show IDS rule names correctly in WebUI log 2017-11-19 17:04 [PATCH] show IDS rule names correctly in WebUI log Peter Müller @ 2017-11-20 15:49 ` Michael Tremer 2017-11-20 18:13 ` Peter Müller 0 siblings, 1 reply; 4+ messages in thread From: Michael Tremer @ 2017-11-20 15:49 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 939 bytes --] Hello, can you explain what this patch is supposed to change? -Michael On Sun, 2017-11-19 at 18:04 +0100, Peter Müller wrote: > Fixes #11519. > > Signed-off-by: Peter Müller <peter.mueller(a)link38.eu> > --- > html/cgi-bin/logs.cgi/ids.dat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.dat > index 44b3abdac..98176d690 100644 > --- a/html/cgi-bin/logs.cgi/ids.dat > +++ b/html/cgi-bin/logs.cgi/ids.dat > @@ -387,7 +387,7 @@ sub processevent > } > ($title,$classification,$priority,$date,$time > ,$srcip,$srcport,$destip,$destport, $sid) = > ("n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a", "n/a"); > @refs = (); > - $_ =~ m/:([0-9]{1,4})\] (.*) \[\*\*\]/; > + $_ =~ m/:([0-9]{1,5})\] (.*) \[\*\*\]/; > $title = &Header::cleanhtml($2,"y"); > } > if ($_ =~ m/Classification: (.*)\] \[Priority: > (\d)\]/) { [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] show IDS rule names correctly in WebUI log 2017-11-20 15:49 ` Michael Tremer @ 2017-11-20 18:13 ` Peter Müller 2017-11-21 12:06 ` Michael Tremer 0 siblings, 1 reply; 4+ messages in thread From: Peter Müller @ 2017-11-20 18:13 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1376 bytes --] Hello Michael, Emerging Threats changed some snort signature IDs to 5 digits a while, which were not displayed in the WebUI since "([0-9]{1,4})" did not match on it. This patch adjusts the regular expression so they are displayed correctly now. Should I send in a second version with this description? Thought the bug ID would be enough... Best regards, Peter Müller > Hello, > > can you explain what this patch is supposed to change? > > -Michael > > On Sun, 2017-11-19 at 18:04 +0100, Peter Müller wrote: > > Fixes #11519. > > > > Signed-off-by: Peter Müller <peter.mueller(a)link38.eu> > > --- > > html/cgi-bin/logs.cgi/ids.dat | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.dat > > index 44b3abdac..98176d690 100644 > > --- a/html/cgi-bin/logs.cgi/ids.dat > > +++ b/html/cgi-bin/logs.cgi/ids.dat > > @@ -387,7 +387,7 @@ sub processevent > > } > > ($title,$classification,$priority,$date,$time > > ,$srcip,$srcport,$destip,$destport, $sid) = > > ("n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a", "n/a"); > > @refs = (); > > - $_ =~ m/:([0-9]{1,4})\] (.*) \[\*\*\]/; > > + $_ =~ m/:([0-9]{1,5})\] (.*) \[\*\*\]/; > > $title = &Header::cleanhtml($2,"y"); > > } > > if ($_ =~ m/Classification: (.*)\] \[Priority: > > (\d)\]/) { ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] show IDS rule names correctly in WebUI log 2017-11-20 18:13 ` Peter Müller @ 2017-11-21 12:06 ` Michael Tremer 0 siblings, 0 replies; 4+ messages in thread From: Michael Tremer @ 2017-11-21 12:06 UTC (permalink / raw) To: development [-- Attachment #1: Type: text/plain, Size: 1803 bytes --] Hi, the bug ID is good, but it didn't have a precise explanation either. I just wanted this on the record so that we know what this patch was supposed to be doing. Yes, please send again. Best, -Michael On Mon, 2017-11-20 at 19:13 +0100, Peter Müller wrote: > Hello Michael, > > Emerging Threats changed some snort signature IDs to 5 digits > a while, which were not displayed in the WebUI since "([0-9]{1,4})" > did not match on it. > > This patch adjusts the regular expression so they are displayed > correctly now. > > Should I send in a second version with this description? Thought > the bug ID would be enough... > > Best regards, > Peter Müller > > > Hello, > > > > can you explain what this patch is supposed to change? > > > > -Michael > > > > On Sun, 2017-11-19 at 18:04 +0100, Peter Müller wrote: > > > Fixes #11519. > > > > > > Signed-off-by: Peter Müller <peter.mueller(a)link38.eu> > > > --- > > > html/cgi-bin/logs.cgi/ids.dat | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.dat > > > index 44b3abdac..98176d690 100644 > > > --- a/html/cgi-bin/logs.cgi/ids.dat > > > +++ b/html/cgi-bin/logs.cgi/ids.dat > > > @@ -387,7 +387,7 @@ sub processevent > > > } > > > ($title,$classification,$priority,$date,$ > > > time > > > ,$srcip,$srcport,$destip,$destport, $sid) = > > > ("n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a","n/a", "n/a"); > > > @refs = (); > > > - $_ =~ m/:([0-9]{1,4})\] (.*) \[\*\*\]/; > > > + $_ =~ m/:([0-9]{1,5})\] (.*) \[\*\*\]/; > > > $title = &Header::cleanhtml($2,"y"); > > > } > > > if ($_ =~ m/Classification: (.*)\] \[Priority: > > > (\d)\]/) { > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-21 12:06 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-11-19 17:04 [PATCH] show IDS rule names correctly in WebUI log Peter Müller 2017-11-20 15:49 ` Michael Tremer 2017-11-20 18:13 ` Peter Müller 2017-11-21 12:06 ` Michael Tremer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox