From: "Peter Müller" <peter.mueller@link38.eu>
To: development@lists.ipfire.org
Subject: Re: [PATCH] correct wrong headline at hardwaregraphs.cgi
Date: Mon, 27 Nov 2017 18:02:26 +0100 [thread overview]
Message-ID: <20171127180226.01180446.peter.mueller@link38.eu> (raw)
In-Reply-To: <CACcs0dTFuGVkiE5etrk-v+XU456WrqnrvZ1XVJjG5aBJ+ioShw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]
Hello,
yes, but I thought it should print at least the right redundancy. :-)
Best regards,
Peter Müller
> The word "Graph" in the titles of all the graphs is redundant (at least in
> English grammar). Its pretty apparent we are looking at a graph. :)
>
> On Nov 24, 2017 11:33 AM, "Peter Müller" <peter.mueller(a)link38.eu> wrote:
>
> > The page description (title and headline) should print
> > "hardware graphs" instead of only mentioning HDDs.
> >
> > Signed-off-by: Peter Müller <peter.mueller(a)link38.eu>
> > ---
> > html/cgi-bin/hardwaregraphs.cgi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/html/cgi-bin/hardwaregraphs.cgi
> > b/html/cgi-bin/hardwaregraphs.cgi
> > index 7b5a848bf..f5999c87e 100644
> > --- a/html/cgi-bin/hardwaregraphs.cgi
> > +++ b/html/cgi-bin/hardwaregraphs.cgi
> > @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){
> > &Graphs::updatehddgraph($querry[0],$querry[1]);
> > }else{
> > &Header::showhttpheaders();
> > - &Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1,
> > '');
> > + &Header::openpage($Lang::tr{'hardware graphs'}, 1, '');
> > &Header::openbigbox('100%', 'left');
> >
> > &Header::getcgihash(\%sensorsettings);
> > --
> > 2.13.6
> >
> >
> >
next parent reply other threads:[~2017-11-27 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACcs0dTFuGVkiE5etrk-v+XU456WrqnrvZ1XVJjG5aBJ+ioShw@mail.gmail.com>
2017-11-27 17:02 ` Peter Müller [this message]
2017-11-24 19:32 Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127180226.01180446.peter.mueller@link38.eu \
--to=peter.mueller@link38.eu \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox