From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@link38.eu>
To: development@lists.ipfire.org
Subject: Re: [PATCH] correct wrong headline at hardwaregraphs.cgi
Date: Mon, 27 Nov 2017 18:02:26 +0100
Message-ID: <20171127180226.01180446.peter.mueller@link38.eu>
In-Reply-To:
 <CACcs0dTFuGVkiE5etrk-v+XU456WrqnrvZ1XVJjG5aBJ+ioShw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3018417464409787324=="
List-Id: <development.lists.ipfire.org>

--===============3018417464409787324==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello,

yes, but I thought it should print at least the right redundancy. :-)

Best regards,
Peter Müller

> The word "Graph" in the titles of all the graphs is redundant  (at least in
> English grammar). Its pretty apparent we are looking at a graph. :)
> 
> On Nov 24, 2017 11:33 AM, "Peter Müller" <peter.mueller(a)link38.eu> wrote:
> 
> > The page description (title and headline) should print
> > "hardware graphs" instead of only mentioning HDDs.
> >
> > Signed-off-by: Peter Müller <peter.mueller(a)link38.eu>
> > ---
> >  html/cgi-bin/hardwaregraphs.cgi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/html/cgi-bin/hardwaregraphs.cgi
> > b/html/cgi-bin/hardwaregraphs.cgi
> > index 7b5a848bf..f5999c87e 100644
> > --- a/html/cgi-bin/hardwaregraphs.cgi
> > +++ b/html/cgi-bin/hardwaregraphs.cgi
> > @@ -73,7 +73,7 @@ if ( $querry[0] =~ "hwtemp"){
> >         &Graphs::updatehddgraph($querry[0],$querry[1]);
> >  }else{
> >         &Header::showhttpheaders();
> > -       &Header::openpage($Lang::tr{'harddisk temperature graphs'}, 1,
> > '');
> > +       &Header::openpage($Lang::tr{'hardware graphs'}, 1, '');
> >         &Header::openbigbox('100%', 'left');
> >
> >         &Header::getcgihash(\%sensorsettings);
> > --
> > 2.13.6
> >
> >
> >  


--===============3018417464409787324==--