From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Held To: development@lists.ipfire.org Subject: [PATCH v2 0/4] proxy.cgi fixes for bugzilla #10852 Date: Mon, 12 Feb 2018 23:19:28 +0100 Message-ID: <20180212221932.29122-1-berny156@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1669938720889391235==" List-Id: --===============1669938720889391235== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit v2 with following changes: Network::network_qual: Improved check if array is fully defined. Honestly, the testsuite of the unpatched file still fails on my IPFire for an unknown reason. The patches fixe the issue for me using perl v5.12.3 as well as v5.26.1. Network::network2bin: 'return undef;' doesn't return an empty list causing lots of headaches. Popular sites strongly recommend to use 'return;' instead of 'return undef;'. Maybe 'return undef;' should be avoided everywhere in IPFire. Have fun, Bernhard --===============1669938720889391235==--