From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Held To: development@lists.ipfire.org Subject: [PATCH v2 1/4] Network::network_equal: fix check if array is fully defined Date: Mon, 12 Feb 2018 23:19:29 +0100 Message-ID: <20180212221932.29122-2-berny156@gmx.de> In-Reply-To: <20180212221932.29122-1-berny156@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0872125736770931098==" List-Id: --===============0872125736770931098== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Correctly check length of list. Credit to Bernhard Bitsch for pointing in the right direction. --- config/cfgroot/network-functions.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-fun= ctions.pl index 2902aabb0..93bb646a6 100644 --- a/config/cfgroot/network-functions.pl +++ b/config/cfgroot/network-functions.pl @@ -111,8 +111,9 @@ sub network_equal { my @bin1 =3D &network2bin($network1); my @bin2 =3D &network2bin($network2); =20 - if (!defined $bin1 || !defined $bin2) { - return undef; + unless (scalar @bin1 =3D=3D 2 && + scalar @bin2 =3D=3D 2) { + return; } =20 if ($bin1[0] eq $bin2[0] && $bin1[1] eq $bin2[1]) { --=20 2.16.1 --===============0872125736770931098==--