From: Bernhard Held <berny156@gmx.de>
To: development@lists.ipfire.org
Subject: [PATCH v2 2/4] Network::network2bin: return an empty list in case of error
Date: Mon, 12 Feb 2018 23:19:30 +0100 [thread overview]
Message-ID: <20180212221932.29122-3-berny156@gmx.de> (raw)
In-Reply-To: <20180212221932.29122-1-berny156@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
'return undef;' will always return a single value 'undef' even in list context.
sub foo { return undef }
if ( my @x = foo() ) {
print "oops, we think we got a result";
}
---
config/cfgroot/network-functions.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-functions.pl
index 93bb646a6..41d36a194 100644
--- a/config/cfgroot/network-functions.pl
+++ b/config/cfgroot/network-functions.pl
@@ -139,7 +139,7 @@ sub network2bin($) {
my $netmask_bin = &ip2bin($netmask);
if (!defined $address_bin || !defined $netmask_bin) {
- return undef;
+ return;
}
my $network_start = $address_bin & $netmask_bin;
--
2.16.1
next prev parent reply other threads:[~2018-02-12 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 22:19 [PATCH v2 0/4] proxy.cgi fixes for bugzilla #10852 Bernhard Held
2018-02-12 22:19 ` [PATCH v2 1/4] Network::network_equal: fix check if array is fully defined Bernhard Held
2018-02-12 22:19 ` Bernhard Held [this message]
2018-02-13 11:52 ` Aw: [PATCH v2 2/4] Network::network2bin: return an empty list in case of error Bernhard Bitsch
2018-02-12 22:19 ` [PATCH v2 3/4] proxy.cgi: strip newline from subnet parameter Bernhard Held
2018-02-12 22:19 ` [PATCH v2 4/4] proxy.cgi: fix subnet comparison for proxy.pac generation Bernhard Held
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212221932.29122-3-berny156@gmx.de \
--to=berny156@gmx.de \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox