From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Held To: development@lists.ipfire.org Subject: [PATCH v2 3/4] proxy.cgi: strip newline from subnet parameter Date: Mon, 12 Feb 2018 23:19:31 +0100 Message-ID: <20180212221932.29122-4-berny156@gmx.de> In-Reply-To: <20180212221932.29122-1-berny156@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0991566052460611346==" List-Id: --===============0991566052460611346== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable $temp[1] might end with a newline; this is unavoidable when specifying serveral subnets. Thus, 'chomp $temp[1];' has to be moved before the comparisons with the green and blue subnets. Otherwise the comparison might always be wrong due to the newline. --- html/cgi-bin/proxy.cgi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi index 6aa14e15a..ea3b41126 100644 --- a/html/cgi-bin/proxy.cgi +++ b/html/cgi-bin/proxy.cgi @@ -3064,12 +3064,12 @@ END foreach (@templist) { @temp =3D split(/\//); + chomp $temp[1]; if ( ($temp[0] ne $netsettings{'GREEN_NETADDRESS'}) && ($temp[1] ne $netsett= ings{'GREEN_NETMASK'}) && ($temp[0] ne $netsettings{'BLUE_NETADDRESS'}) && ($temp[1] ne $netsetti= ngs{'BLUE_NETMASK'}) ) { - chomp $temp[1]; print FILE " ||\n (isInNet(myIpAddress(), \"$temp[0]\", \"$temp[1]\= "))"; } } --=20 2.16.1 --===============0991566052460611346==--