From: Bernhard Held <berny156@gmx.de>
To: development@lists.ipfire.org
Subject: [PATCH v3 0/4] proxy.cgi fixes for bugzilla #10852
Date: Wed, 14 Feb 2018 20:35:18 +0100 [thread overview]
Message-ID: <20180214193522.26880-1-berny156@gmx.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
v2 -> v3
- Network::network2bin: use 'return ();' instead of plain 'return;'
- Network::network_qual: fix identation problem
- proxy.cgi::writepacfile: use 'chomp(@templist);' once before loop
v1 -> v2
- Network::network_qual: Improved check if array is fully defined.
Honestly, the testsuite of the unpatched file still fails on my IPFire
for an unknown reason. The patches fixe the issue for me using perl
v5.12.3 as well as v5.26.1.
- Network::network2bin: 'return undef;' doesn't return an empty list
causing lots of headaches. Popular sites strongly recommend to use
'return;' instead of 'return undef;'. Maybe 'return undef;' should be
avoided everywhere in IPFire.
Have fun,
Bernhard
next reply other threads:[~2018-02-14 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 19:35 Bernhard Held [this message]
2018-02-14 19:35 ` [PATCH v3 1/4] Network::network_equal: fix check if array is fully defined Bernhard Held
2018-02-14 22:11 ` Michael Tremer
2018-02-14 19:35 ` [PATCH v3 2/4] Network::network2bin: return an empty list in case of error Bernhard Held
2018-02-14 22:12 ` Michael Tremer
2018-02-14 22:59 ` Aw: " Bernhard Bitsch
2018-02-14 19:35 ` [PATCH v3 3/4] proxy.cgi: strip newline from subnet parameters Bernhard Held
2018-02-14 23:14 ` Aw: " Bernhard Bitsch
2018-02-15 6:38 ` Bernhard Held
2018-02-14 19:35 ` [PATCH v3 4/4] proxy.cgi: fix subnet comparison for proxy.pac generation Bernhard Held
2018-02-14 22:14 ` Michael Tremer
2018-02-15 7:15 ` Bernhard Held
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214193522.26880-1-berny156@gmx.de \
--to=berny156@gmx.de \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox