From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Held <berny156@gmx.de>
To: development@lists.ipfire.org
Subject: [PATCH v3 0/4] proxy.cgi fixes for bugzilla #10852 
Date: Wed, 14 Feb 2018 20:35:18 +0100
Message-ID: <20180214193522.26880-1-berny156@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5022073602775833506=="
List-Id: <development.lists.ipfire.org>

--===============5022073602775833506==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

v2 -> v3

- Network::network2bin: use 'return ();' instead of plain 'return;'

- Network::network_qual: fix identation problem

- proxy.cgi::writepacfile: use 'chomp(@templist);' once before loop

v1 -> v2

- Network::network_qual: Improved check if array is fully defined.
  Honestly, the testsuite of the unpatched file still fails on my IPFire
  for an unknown reason. The patches fixe the issue for me using perl
  v5.12.3 as well as v5.26.1.

- Network::network2bin: 'return undef;' doesn't return an empty list
  causing lots of headaches. Popular sites strongly recommend to use
  'return;' instead of 'return undef;'. Maybe 'return undef;' should be
  avoided everywhere in IPFire.

Have fun,
Bernhard

--===============5022073602775833506==--