From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Held To: development@lists.ipfire.org Subject: [PATCH v3 2/4] Network::network2bin: return an empty list in case of error Date: Wed, 14 Feb 2018 20:35:20 +0100 Message-ID: <20180214193522.26880-3-berny156@gmx.de> In-Reply-To: <20180214193522.26880-1-berny156@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3246359868588174840==" List-Id: --===============3246359868588174840== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable 'return undef;' will always return a single value 'undef' even in list contex= t. sub foo { return undef } if ( my @x =3D foo() ) { print "oops, we think we got a result"; } --- config/cfgroot/network-functions.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-fun= ctions.pl index 070e14d0f..7cd56f799 100644 --- a/config/cfgroot/network-functions.pl +++ b/config/cfgroot/network-functions.pl @@ -139,7 +139,7 @@ sub network2bin($) { my $netmask_bin =3D &ip2bin($netmask); =20 if (!defined $address_bin || !defined $netmask_bin) { - return undef; + return (); } =20 my $network_start =3D $address_bin & $netmask_bin; --=20 2.16.1 --===============3246359868588174840==--