From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: [PATCH 1/2] Pakfire: abort download if downloaded size is emtpy or zero Date: Mon, 22 Oct 2018 19:58:12 +0200 Message-ID: <20181022175813.3938-1-peter.mueller@link38.eu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1020026594452289663==" List-Id: --===============1020026594452289663== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In case a download fails for whatever reason, and the downloaded file size cannot be determined or is zero, Pakfire should abort. Signed-off-by: Peter M=C3=BCller --- src/pakfire/lib/functions.pl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl index 12a405bd7..bbc580ad2 100644 --- a/src/pakfire/lib/functions.pl +++ b/src/pakfire/lib/functions.pl @@ -180,7 +180,14 @@ sub fetchfile { my $result =3D $ua->head($url); my $remote_headers =3D $result->headers; $total_size =3D $remote_headers->content_length; - logger("DOWNLOAD INFO: $file has size of $total_size bytes"); + + # validate if file download was successful (size <=3D 0) + if ( $total_size eq "0" || not $total_size ) { + logger("DOWNLOAD ERROR: download of $file failed with size '$total_size' = bytes"); + return 1; + } else { + logger("DOWNLOAD INFO: $file has size of $total_size bytes"); + } =09 my $response =3D $ua->get($url, ':content_cb' =3D> \&callback ); message(""); --=20 2.16.4 --===============1020026594452289663==--