From: Tapani Tarvainen <ipfire@tapanitarvainen.fi>
To: development@lists.ipfire.org
Subject: Re: validfqdn
Date: Fri, 14 Dec 2018 10:25:00 +0200 [thread overview]
Message-ID: <20181214082500.GE14074@tarvainen.info> (raw)
In-Reply-To: <puuhjv$e7a$1@tuscan3.grantura.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On Thu, Dec 13, 2018 at 09:06:06PM +0000, Bob Brewer (ipfire-devel(a)grantura.co.uk) wrote:
> > http://data.iana.org/TLD/tlds-alpha-by-domain.txt
> >
> There are some weird domains in there and many are new to me so maybe my
> patch needs to be updated to allow for these but I notice that there aren't
> any purely numeric TLDs in that list.
No, and I don't expect such in the next new gtld round either, though some
with embedded numbers might appear.
> > I assume that those will no longer be usable after your patch. Can you
> > confirm that?
> >
> MY patch brings IPfire's validfqdn to be the same as the one in the latest
> IPCop version. It looks like we need to add a '-' to the regex string to
> make comply with the domains listed above.
Dash (-) should be allowed except in the beginning and end (that applies
to other parts of the fqdn, too, but there pure numeric ones can also
occur).
It would also be good to think where non-ASCII names should be allowed
without requiring user to convert them to punycode first.
--
Tapani Tarvainen
prev parent reply other threads:[~2018-12-14 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 22:48 validfqdn Bob Brewer
2018-12-13 16:36 ` validfqdn Michael Tremer
2018-12-13 21:06 ` validfqdn Bob Brewer
2018-12-14 8:25 ` Tapani Tarvainen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214082500.GE14074@tarvainen.info \
--to=ipfire@tapanitarvainen.fi \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox