From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH] convert-snort: Fix logic for detecting enough free disk space.
Date: Mon, 08 Apr 2019 20:02:53 +0200 [thread overview]
Message-ID: <20190408180253.5394-1-stefan.schantl@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
The subfunction only will return something if the check fails - so the logic
of the if statement was wrong set and the downloader only was called if
this check failed and to less diskspace would be available.
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
config/suricata/convert-snort | 3 +++
1 file changed, 3 insertions(+)
diff --git a/config/suricata/convert-snort b/config/suricata/convert-snort
index ca650b149..19aa38fbc 100644
--- a/config/suricata/convert-snort
+++ b/config/suricata/convert-snort
@@ -231,6 +231,9 @@ if (-f $snort_rules_tarball) {
} else {
# Check if enought disk space is available.
if(&IDS::checkdiskspace()) {
+ # Print error message.
+ print "Could not download ruleset - Not enough free diskspace available.\n";
+ } else {
# Call the download function and grab the new ruleset.
&IDS::downloadruleset();
}
--
2.20.1
reply other threads:[~2019-04-08 18:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408180253.5394-1-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox