From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH v2 13/15] QoS: Drop support for setting TOS bits per class
Date: Mon, 21 Oct 2019 20:45:37 +0200 [thread overview]
Message-ID: <20191021184539.12758-13-michael.tremer@ipfire.org> (raw)
In-Reply-To: <20191021184539.12758-1-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 4968 bytes --]
This is useless since no ISP will evaluate those settings
any more and it has a rather large impact on throughput.
Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
config/qos/makeqosscripts.pl | 26 +-------------------------
html/cgi-bin/qos.cgi | 12 ------------
2 files changed, 1 insertion(+), 37 deletions(-)
diff --git a/config/qos/makeqosscripts.pl b/config/qos/makeqosscripts.pl
index 6f307c743..96c784c89 100644
--- a/config/qos/makeqosscripts.pl
+++ b/config/qos/makeqosscripts.pl
@@ -134,7 +134,6 @@ case "\$1" in
echo "[iptables]"
iptables -t mangle -n -L QOS-OUT -v -x 2> /dev/null
iptables -t mangle -n -L QOS-INC -v -x 2> /dev/null
- iptables -t mangle -n -L QOS-TOS -v -x 2> /dev/null
exit 0
;;
esac
@@ -211,9 +210,7 @@ print <<END
### ADD QOS-OUT CHAIN TO THE MANGLE TABLE IN IPTABLES
iptables -t mangle -N QOS-OUT
- iptables -t mangle -N QOS-TOS
iptables -t mangle -I POSTROUTING -o $qossettings{'RED_DEV'} -j QOS-OUT
- iptables -t mangle -A POSTROUTING -o $qossettings{'RED_DEV'} -j QOS-TOS
### Don't change mark on traffic for the ipsec tunnel
iptables -t mangle -A QOS-OUT -m mark --mark 50 -j RETURN
@@ -431,7 +428,6 @@ print <<END
### ADD QOS-INC CHAIN TO THE MANGLE TABLE IN IPTABLES
iptables -t mangle -N QOS-INC
iptables -t mangle -A PREROUTING -i $qossettings{'RED_DEV'} -j QOS-INC
- iptables -t mangle -A PREROUTING -i $qossettings{'RED_DEV'} -j QOS-TOS
# If the packet is already marked, then skip the processing
iptables -t mangle -A QOS-INC -m mark ! --mark 0 -j RETURN
@@ -518,22 +514,6 @@ print <<END
# Save mark in connection tracking
iptables -t mangle -A QOS-INC -j CONNMARK --save-mark
- ### SETTING TOS BITS
-END
-;
- foreach $classentry (sort @classes)
- {
- @classline = split( /\;/, $classentry );
- $qossettings{'CLASS'} = $classline[1];
- $qossettings{'TOS'} = abs $classline[7] * 2;
- if ($qossettings{'TOS'} ne "0") {
- print "\tiptables -t mangle -A QOS-TOS -m mark --mark $qossettings{'CLASS'} -j TOS --set-tos $qossettings{'TOS'}\n";
- print "\tiptables -t mangle -A QOS-TOS -m mark --mark $qossettings{'CLASS'} -j RETURN\n";
- }
- }
-
-print <<END
-
## STARTING COLLECTOR
/usr/local/bin/qosd $qossettings{'RED_DEV'} >/dev/null 2>&1
/usr/local/bin/qosd $qossettings{'IMQ_DEV'} >/dev/null 2>&1
@@ -568,15 +548,11 @@ print <<END
iptables -t mangle --delete PREROUTING -i $qossettings{'RED_DEV'} -p esp -j RETURN >/dev/null 2>&1
iptables -t mangle --delete PREROUTING -i $qossettings{'RED_DEV'} -p ip -j RETURN >/dev/null 2>&1
iptables -t mangle --delete POSTROUTING -o $qossettings{'RED_DEV'} -j QOS-OUT >/dev/null 2>&1
- iptables -t mangle --delete POSTROUTING -o $qossettings{'RED_DEV'} -j QOS-TOS >/dev/null 2>&1
+ iptables -t mangle --delete PREROUTING -i $qossettings{'RED_DEV'} -j QOS-INC >/dev/null 2>&1
iptables -t mangle --flush QOS-OUT >/dev/null 2>&1
iptables -t mangle --delete-chain QOS-OUT >/dev/null 2>&1
- iptables -t mangle --delete PREROUTING -i $qossettings{'RED_DEV'} -j QOS-INC
- iptables -t mangle --delete PREROUTING -i $qossettings{'RED_DEV'} -j QOS-TOS
iptables -t mangle --flush QOS-INC >/dev/null 2>&1
iptables -t mangle --delete-chain QOS-INC >/dev/null 2>&1
- iptables -t mangle --flush QOS-TOS >/dev/null 2>&1
- iptables -t mangle --delete-chain QOS-TOS >/dev/null 2>&1
# remove l7-filter
iptables -t mangle --delete PREROUTING -m layer7 --l7proto unset
diff --git a/html/cgi-bin/qos.cgi b/html/cgi-bin/qos.cgi
index 320eef67d..8211a3ca0 100644
--- a/html/cgi-bin/qos.cgi
+++ b/html/cgi-bin/qos.cgi
@@ -883,18 +883,6 @@ END
<tr><td width='33%' align='right'>Ceilburst:
<td width='33%' align='left'><input type='text' size='20' name='CBURST' maxlength='8' value="$qossettings{'CBURST'}" />
<td width='33%' align='center'>
-END
-;
- $selected{'TOS'}{$qossettings{'TOS'}} = "selected='selected'";
-print <<END
- <tr><td width='33%' align='right'>TOS-Bit:
- <td width='33%' align='left'><select name='TOS'>
- <option value='0' $selected{'TOS'}{'0'}>$Lang::tr{'disabled'} (0)</option>
- <option value='8' $selected{'TOS'}{'8'}>$Lang::tr{'min delay'} (8)</option>
- <option value='4' $selected{'TOS'}{'4'}>$Lang::tr{'max throughput'} (4)</option>
- <option value='2' $selected{'TOS'}{'2'}>$Lang::tr{'max reliability'} (2)</option>
- <option value='1' $selected{'TOS'}{'1'}>$Lang::tr{'min costs'} (1)</option></select>
- <td width='33%' align='center'>
<tr><td width='33%' align='right'>$Lang::tr{'remark'}:
<td width='66%' colspan='2' align='left'><input type='text' name='REMARK' size='40' maxlength='40' value="$qossettings{'REMARK'}" />
<tr><td width='33%' align='right'><img src='/blob.gif' alt='*' /> $Lang::tr{'required field'}
--
2.12.2
next prev parent reply other threads:[~2019-10-21 18:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 18:45 [PATCH v2 01/15] QoS: Do not manually load iptables modules Michael Tremer
2019-10-21 18:45 ` [PATCH v2 02/15] QoS: Use Intermediate Functional Block Michael Tremer
2019-10-21 18:45 ` [PATCH v2 03/15] QoS: Tidy up qdiscs after QoS is being stopped Michael Tremer
2019-10-21 18:45 ` [PATCH v2 04/15] QoS: Start qosd immediately Michael Tremer
2019-10-21 18:45 ` [PATCH v2 05/15] QoS: Do not delete egress qdisc after classes have been created Michael Tremer
2019-10-21 18:45 ` [PATCH v2 06/15] linux+iptables: Drop support for IMQ Michael Tremer
2019-10-21 18:45 ` [PATCH v2 07/15] QoS: Suppress an error message when cleaning up from previous runs Michael Tremer
2019-10-21 18:45 ` [PATCH v2 08/15] QoS: Drop support for subclasses Michael Tremer
2019-10-21 18:45 ` [PATCH v2 09/15] Revert "Make IMQ Switchable between PREROUTING and POSTROUTING" Michael Tremer
2019-10-21 18:45 ` [PATCH v2 10/15] QoS: Use CONNMARK to mark connections in connection tracking Michael Tremer
2019-10-21 18:45 ` [PATCH v2 11/15] QoS: Classify incoming traffic in PREROUTING Michael Tremer
2019-10-21 18:45 ` [PATCH v2 12/15] QoS: Remove some IPsec rules which never worked Michael Tremer
2019-10-21 18:45 ` Michael Tremer [this message]
2019-10-21 18:45 ` [PATCH v2 14/15] QoS: No longer set TOS bits for ACK packets Michael Tremer
2019-10-21 18:45 ` [PATCH v2 15/15] QoS: Delete more unused iptables commands Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021184539.12758-13-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox