From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim FitzGeorge To: development@lists.ipfire.org Subject: [PATCH] Fix network-functions net membership check Date: Mon, 23 Dec 2019 18:54:12 +0000 Message-ID: <20191223185412.13338-1-ipfr@tfitzgeorge.me.uk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0268985754533003516==" List-Id: --===============0268985754533003516== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Replace textual comparison of two number with arithmetic in ip_address_in_Network(). Fixes: 12263 Signed-off-by: Tim FitzGeorge --- config/cfgroot/network-functions.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-fun= ctions.pl index 8649d0502..589044c2a 100644 --- a/config/cfgroot/network-functions.pl +++ b/config/cfgroot/network-functions.pl @@ -295,7 +295,7 @@ sub ip_address_in_network($$) { # Find end address my $broadcast_bin =3D $network_bin ^ (~$netmask_bin % 2 ** 32); =20 - return (($address_bin ge $network_bin) && ($address_bin le $broadcast_bin)); + return (($address_bin =3D> $network_bin) && ($address_bin <=3D $broadcast_b= in)); } =20 sub setup_upstream_proxy() { --=20 2.16.4 --===============0268985754533003516==--