* [PATCH] Fix network-functions net membership check
@ 2019-12-23 18:54 Tim FitzGeorge
2019-12-23 21:27 ` Aw: " Bernhard Bitsch
0 siblings, 1 reply; 2+ messages in thread
From: Tim FitzGeorge @ 2019-12-23 18:54 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
Replace textual comparison of two number with arithmetic in
ip_address_in_Network().
Fixes: 12263
Signed-off-by: Tim FitzGeorge <ipfr(a)tfitzgeorge.me.uk>
---
config/cfgroot/network-functions.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-functions.pl
index 8649d0502..589044c2a 100644
--- a/config/cfgroot/network-functions.pl
+++ b/config/cfgroot/network-functions.pl
@@ -295,7 +295,7 @@ sub ip_address_in_network($$) {
# Find end address
my $broadcast_bin = $network_bin ^ (~$netmask_bin % 2 ** 32);
- return (($address_bin ge $network_bin) && ($address_bin le $broadcast_bin));
+ return (($address_bin => $network_bin) && ($address_bin <= $broadcast_bin));
}
sub setup_upstream_proxy() {
--
2.16.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Aw: [PATCH] Fix network-functions net membership check
2019-12-23 18:54 [PATCH] Fix network-functions net membership check Tim FitzGeorge
@ 2019-12-23 21:27 ` Bernhard Bitsch
0 siblings, 0 replies; 2+ messages in thread
From: Bernhard Bitsch @ 2019-12-23 21:27 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]
Hi,
> Gesendet: Montag, 23. Dezember 2019 um 19:54 Uhr
> Von: "Tim FitzGeorge" <ipfr(a)tfitzgeorge.me.uk>
> An: development(a)lists.ipfire.org
> Betreff: [PATCH] Fix network-functions net membership check
>
> Replace textual comparison of two number with arithmetic in
> ip_address_in_Network().
>
> Fixes: 12263
> Signed-off-by: Tim FitzGeorge <ipfr(a)tfitzgeorge.me.uk>
> ---
> config/cfgroot/network-functions.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-functions.pl
> index 8649d0502..589044c2a 100644
> --- a/config/cfgroot/network-functions.pl
> +++ b/config/cfgroot/network-functions.pl
> @@ -295,7 +295,7 @@ sub ip_address_in_network($$) {
> # Find end address
> my $broadcast_bin = $network_bin ^ (~$netmask_bin % 2 ** 32);
>
> - return (($address_bin ge $network_bin) && ($address_bin le $broadcast_bin));
> + return (($address_bin => $network_bin) && ($address_bin <= $broadcast_bin));
should work if you change '=>' to '>='
> }
>
> sub setup_upstream_proxy() {
> --
> 2.16.4
>
>
Bernhard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-23 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-23 18:54 [PATCH] Fix network-functions net membership check Tim FitzGeorge
2019-12-23 21:27 ` Aw: " Bernhard Bitsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox